Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace copy_dir #103

Open
theduke opened this issue Mar 9, 2021 · 0 comments
Open

Replace copy_dir #103

theduke opened this issue Mar 9, 2021 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@theduke
Copy link
Owner

theduke commented Mar 9, 2021 •
edited
Loading

copy_dir is quite outdated and tends to introduce a duplicate dependency on walkdir.

We can either ship a compressed version of the code, which is then uncompressed instead of copying the source directory.
Or switch to a different dependency like fs-extra.

See libquickjs-sys/build.rs.
@theduke theduke added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@theduke