Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support wasm32-unknown-unknown Target #73

Open
dsherret opened this issue Jun 3, 2020 · 7 comments
Open

Support wasm32-unknown-unknown Target #73

dsherret opened this issue Jun 3, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@dsherret
Copy link

dsherret commented Jun 3, 2020

Thanks for this project!

Is there any way to compile this in a lib crate to target wasm32-unknown-unknown? (ex. cargo build --release --target=wasm32-unknown-unknown)

I'm suspecting no. I tried and got this error:

error: failed to run custom build command for `libquickjs-sys v0.6.0`

Caused by:
  process didn't exit successfully: `/mnt/v/dprint/crates/test-plugin/target/release/build/libquickjs-sys-7f85a6e12a75c9e1/build-script-build` (exit code: 1)
--- stdout
TARGET = Some("wasm32-unknown-unknown")
HOST = Some("x86_64-unknown-linux-gnu")
CC_wasm32-unknown-unknown = None
CC_wasm32_unknown_unknown = None
TARGET_CC = None
CC = None
CFLAGS_wasm32-unknown-unknown = None
CFLAGS_wasm32_unknown_unknown = None
TARGET_CFLAGS = None
CFLAGS = None
CRATE_CC_NO_DEFAULTS = None
DEBUG = Some("false")
CC_wasm32-unknown-unknown = None
CC_wasm32_unknown_unknown = None
TARGET_CC = None
CC = None
CFLAGS_wasm32-unknown-unknown = None
CFLAGS_wasm32_unknown_unknown = None
TARGET_CFLAGS = None
CFLAGS = None
CRATE_CC_NO_DEFAULTS = None
CC_wasm32-unknown-unknown = None
CC_wasm32_unknown_unknown = None
TARGET_CC = None
CC = None
CFLAGS_wasm32-unknown-unknown = None
CFLAGS_wasm32_unknown_unknown = None
TARGET_CFLAGS = None
CFLAGS = None
CRATE_CC_NO_DEFAULTS = None
CC_wasm32-unknown-unknown = None
CC_wasm32_unknown_unknown = None
TARGET_CC = None
CC = None
CFLAGS_wasm32-unknown-unknown = None
CFLAGS_wasm32_unknown_unknown = None
TARGET_CFLAGS = None
CFLAGS = None
CRATE_CC_NO_DEFAULTS = None
CC_wasm32-unknown-unknown = None
CC_wasm32_unknown_unknown = None
TARGET_CC = None
CC = None
CFLAGS_wasm32-unknown-unknown = None
CFLAGS_wasm32_unknown_unknown = None
TARGET_CFLAGS = None
CFLAGS = None
CRATE_CC_NO_DEFAULTS = None
CC_wasm32-unknown-unknown = None
CC_wasm32_unknown_unknown = None
TARGET_CC = None
CC = None
CFLAGS_wasm32-unknown-unknown = None
CFLAGS_wasm32_unknown_unknown = None
TARGET_CFLAGS = None
CFLAGS = None
CRATE_CC_NO_DEFAULTS = None
CC_wasm32-unknown-unknown = None
CC_wasm32_unknown_unknown = None
TARGET_CC = None
CC = None
CFLAGS_wasm32-unknown-unknown = None
CFLAGS_wasm32_unknown_unknown = None
TARGET_CFLAGS = None
CFLAGS = None
CRATE_CC_NO_DEFAULTS = None
CC_wasm32-unknown-unknown = None
CC_wasm32_unknown_unknown = None
TARGET_CC = None
CC = None
CFLAGS_wasm32-unknown-unknown = None
CFLAGS_wasm32_unknown_unknown = None
TARGET_CFLAGS = None
CFLAGS = None
CRATE_CC_NO_DEFAULTS = None
CC_wasm32-unknown-unknown = None
CC_wasm32_unknown_unknown = None
TARGET_CC = None
CC = None
CFLAGS_wasm32-unknown-unknown = None
CFLAGS_wasm32_unknown_unknown = None
TARGET_CFLAGS = None
CFLAGS = None
CRATE_CC_NO_DEFAULTS = None
CC_wasm32-unknown-unknown = None
CC_wasm32_unknown_unknown = None
TARGET_CC = None
CC = None
CFLAGS_wasm32-unknown-unknown = None
CFLAGS_wasm32_unknown_unknown = None
TARGET_CFLAGS = None
CFLAGS = None
CRATE_CC_NO_DEFAULTS = None
CC_wasm32-unknown-unknown = None
CC_wasm32_unknown_unknown = None
TARGET_CC = None
CC = None
CFLAGS_wasm32-unknown-unknown = None
CFLAGS_wasm32_unknown_unknown = None
TARGET_CFLAGS = None
CFLAGS = None
CRATE_CC_NO_DEFAULTS = None
CC_wasm32-unknown-unknown = None
CC_wasm32_unknown_unknown = None
TARGET_CC = None
CC = None
CFLAGS_wasm32-unknown-unknown = None
CFLAGS_wasm32_unknown_unknown = None
TARGET_CFLAGS = None
CFLAGS = None
CRATE_CC_NO_DEFAULTS = None
CC_wasm32-unknown-unknown = None
CC_wasm32_unknown_unknown = None
TARGET_CC = None
CC = None
CFLAGS_wasm32-unknown-unknown = None
CFLAGS_wasm32_unknown_unknown = None
TARGET_CFLAGS = None
CFLAGS = None
CRATE_CC_NO_DEFAULTS = None
CC_wasm32-unknown-unknown = None
CC_wasm32_unknown_unknown = None
TARGET_CC = None
CC = None
CFLAGS_wasm32-unknown-unknown = None
CFLAGS_wasm32_unknown_unknown = None
TARGET_CFLAGS = None
CFLAGS = None
CRATE_CC_NO_DEFAULTS = None
running: "clang" "-O2" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=wasm32-unknown-unknown" "-Wall" "-Wextra" "-D_GNU_SOURCE" "-DCONFIG_VERSION=\"2020-04-12\"" "-DCONFIG_BIGNUM" "-o" "/mnt/v/dprint/crates/test-plugin/target/wasm32-unknown-unknown/release/build/libquickjs-sys-62382c90b72b3b52/out/quickjs/cutils.o" "-c" "/mnt/v/dprint/crates/test-plugin/target/wasm32-unknown-unknown/release/build/libquickjs-sys-62382c90b72b3b52/out/quickjs/cutils.c"
cargo:warning=In file included from /mnt/v/dprint/crates/test-plugin/target/wasm32-unknown-unknown/release/build/libquickjs-sys-62382c90b72b3b52/out/quickjs/cutils.c:25:
cargo:warning=/usr/include/stdlib.h:25:10: fatal error: 'bits/libc-header-start.h' file not found
cargo:warning=#include <bits/libc-header-start.h>
cargo:warning=         ^~~~~~~~~~~~~~~~~~~~~~~~~~
cargo:warning=1 error generated.
exit code: 1

--- stderr
Compiling quickjs...


error occurred: Command "clang" "-O2" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=wasm32-unknown-unknown" "-Wall" "-Wextra" "-D_GNU_SOURCE" "-DCONFIG_VERSION=\"2020-04-12\"" "-DCONFIG_BIGNUM" "-o" "/mnt/v/dprint/crates/test-plugin/target/wasm32-unknown-unknown/release/build/libquickjs-sys-62382c90b72b3b52/out/quickjs/cutils.o" "-c" "/mnt/v/dprint/crates/test-plugin/target/wasm32-unknown-unknown/release/build/libquickjs-sys-62382c90b72b3b52/out/quickjs/cutils.c" with args "clang" did not execute successfully (status code exit code: 1).
@dsherret
Copy link
Author

dsherret commented Jun 19, 2020 •
edited
Loading

I was able to compile this only on Mac by doing:

quick-js = "=0.3.0"

Once it's bumped to 0.3.3 it no longer works and the following error occurs:

cargo:warning=/test/target/wasm32-unknown-unknown/release/build/libquickjs-sys-3ceefb9672fa932f/out/quickjs/cutils.c:25:10: fatal error: 'stdlib.h' file not found
cargo:warning=#include <stdlib.h>
cargo:warning=         ^~~~~~~~~~
cargo:warning=1 error generated.
exit code: 1

Not sure why it only works on Mac, but at least it's working now!

That said, it looks like it doesn't work exactly because the following functions then need to be provided as imports to the wasm instance.

21 link errors:
(1 of 21) Import not found, namespace: env, name: __JS_FreeValue
(2 of 21) Import not found, namespace: env, name: JS_ToCStringLen2
(3 of 21) Import not found, namespace: env, name: JS_FreeCString
(4 of 21) Import not found, namespace: env, name: JS_IsArray
(5 of 21) Import not found, namespace: env, name: JS_GetOwnPropertyNames
(6 of 21) Import not found, namespace: env, name: JS_GetPropertyInternal
(7 of 21) Import not found, namespace: env, name: JS_AtomToString
(8 of 21) Import not found, namespace: env, name: JS_GetPropertyStr
(9 of 21) Import not found, namespace: env, name: JS_GetPropertyUint32
(10 of 21) Import not found, namespace: env, name: JS_FreeAtom
(11 of 21) Import not found, namespace: env, name: js_free
(12 of 21) Import not found, namespace: env, name: JS_ToString
(13 of 21) Import not found, namespace: env, name: JS_FreeContext
(14 of 21) Import not found, namespace: env, name: JS_FreeRuntime
(15 of 21) Import not found, namespace: env, name: JS_NewRuntime
(16 of 21) Import not found, namespace: env, name: JS_NewContext
(17 of 21) Import not found, namespace: env, name: JS_GetGlobalObject
(18 of 21) Import not found, namespace: env, name: JS_GetException
(19 of 21) Import not found, namespace: env, name: JS_ExecutePendingJob
(20 of 21) Import not found, namespace: env, name: JS_Eval
(21 of 21) Import not found, namespace: env, name: JS_Call

I wonder what determines these to show up needing to be imports? Edit: Oh, ok... these are the quickjs bindings that get used in the rust code.

@chayleaf
Copy link
Contributor

chayleaf commented Oct 17, 2020 •
edited
Loading

obviously there always is a way, but it isn't easy to do in this case - wasm32-unknown-unknown c interop is in an extremely basic state at the moment - there's no libc and the abi doesn't perfectly match.

I did compile it successfully by doing some modifications to emscripten (which definitely can't be pushed to production) and linking a modified version of quickjs to the resulting modified emscripten-compiled libc, it's definitely not something that can be achieved by making modifications to this crate alone

@twop
Copy link

twop commented Dec 3, 2020 •
edited
Loading

Thanks for your effort! <3

I want to build quickjs as a wasm based mini vm and having wasm32-unknown-unknown target support would be super handy.

I have more experience working with rust/wasm than emscripten :(, I was able to build https://github.com/justjake/quickjs-emscripten but would prefer to have a rust/wasm version.

@theduke
Copy link
Owner

theduke commented Feb 4, 2021

I'm looking into this again.

It will require quite a few patches to the codebase though, sadly.

@theduke theduke added the enhancement New feature or request label Feb 4, 2021
@theduke theduke changed the title Possible to compile to target wasm32-unknown-unknown? Compile to wasm32-unknown-unknown Feb 4, 2021
@theduke theduke changed the title Compile to wasm32-unknown-unknown Support wasm32-unknown-unknown Target Feb 4, 2021
@xu-cheng xu-cheng mentioned this issue Feb 6, 2021
Open
@theduke
Copy link
Owner

theduke commented Feb 20, 2021 •
edited
Loading

Good news!

I managed to transpile Quickjs to Rust with c2rust, and I have the code running fine after some relatively sparse refactoring.

I will need to patch out the libc dependency, but a WASM build is relatively easy to do now.

@theduke theduke closed this as completed Feb 20, 2021
@theduke theduke reopened this Feb 20, 2021
@theduke
Copy link
Owner

theduke commented Feb 24, 2021

Little progress update:

I've done quite extensive cleanup of the c2rust generated code.
I probably introduced some bugs during reafactoring of the types, but the basics all seem to work on x86.
The code builds fine on wasm, but setting up a Context currently fails with an error.

I will probably continue to rewrite it step by step to idiomatic Rust, which is a lot of work but probably worthwile and can be done incrementally.

That also means that the code will diverge significantly from QuickJS, and will live in a different repo with a new name.

If anyone wants to play with the code or, even better, help out with porting, a preliminary version is published here: https://github.com/theduke/slimjs

@jakob-lilliemarck
Copy link

Hi @theduke
I've been trying out your crate for a bit while trying to pick up some rust skills - awesome work!

I've ran into the same issue as mr @dsherret describes above and had a look at the quickjs-fork in the link above. I noticed it's been about a year since the last commit - did you abandon it or did you found a way forward with this?

@zicklag zicklag mentioned this issue Jul 22, 2022
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@theduke @dsherret @twop @chayleaf @jakob-lilliemarck