Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFG-Viewer Integration: Canvas height does not consider height of container #71

Open
markusweigelt opened this issue Nov 5, 2024 · 2 comments

Comments

@markusweigelt
Copy link

markusweigelt commented Nov 5, 2024

Canvas height should be based on the height of the container. Currently, there are unnecessary scrollbars here, even though there is enough space to display the model.

image

Additionally, the fullscreen and download buttons are not visible.

@markusweigelt markusweigelt changed the title Canvas height does not consider height of container DFG-Viewer Integration: Canvas height does not consider height of container Nov 5, 2024
@thedworak
Copy link
Owner

Now it's based on the container dimensions, will be updated in next release

@markusweigelt
Copy link
Author

markusweigelt commented Nov 22, 2024

Currently, the scrollbars are still displayed, and you have to scroll to access the buttons for download and fullscreen.

image

Tested against the current master branch.

Is there a way to provide a stable version without a release, for example, via a stable branch? Releases could then be generated from this branch. Otherwise, too much time passes between fixing issues and making them available.

@ClemensBeck ClemensBeck reopened this Nov 23, 2024
@ClemensBeck ClemensBeck added Testing and removed Done labels Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants