Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isNotRhelHost regular expression too restrictive #919

Closed
Thorben-D opened this issue Oct 30, 2024 · 0 comments
Closed

isNotRhelHost regular expression too restrictive #919

Thorben-D opened this issue Oct 30, 2024 · 0 comments

Comments

@Thorben-D
Copy link
Contributor

Thorben-D commented Oct 30, 2024 •
edited
Loading

In the recently merged PR #911, a helper method isNotRhelHost was introduced to determine whether a host uses RHEL as an operating system.
The regex that function uses is too restrictive in it's current form, as it does not recognize short-hands such as RHEL.
Thorben-D added a commit to Thorben-D/foreman_rh_cloud that referenced this issue Oct 30, 2024
@Thorben-D
Fixes theforeman#919 - isNotRhelHost regex too restrictive
41806c3 
- Changed regex to be more wide-ranging
- Fixed a bug in InsightsTotalRiskChartWrapper
where the wrong parameter was passed to isNotRhelHost
Thorben-D added a commit to Thorben-D/foreman_rh_cloud that referenced this issue Nov 2, 2024
@Thorben-D
Fixes theforeman#919 - isNotRhelHost regex too restrictive
a902fa1 
- Changed regex to be more wide-ranging
- Fixed a bug in InsightsTotalRiskChartWrapper
where the wrong parameter was passed to isNotRhelHost
Thorben-D added a commit to Thorben-D/foreman_rh_cloud that referenced this issue Nov 2, 2024
@Thorben-D
Fixes theforeman#919 - isNotRhelHost regex too restrictive
42cbacb 
- Changed regex to be more wide-ranging
- Fixed a bug in InsightsTotalRiskChartWrapper
where the wrong parameter was passed to isNotRhelHost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Thorben-D