New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contribute: create test database #1621

Open

m-bucher opened this issue Jun 22, 2020 · 1 comment

Contributor

m-bucher commented Jun 22, 2020

https://github.com/theforeman/theforeman.org/blob/9137547dd1b8deffa83508f1f6099d4c12955d95/contribute.md#setup-test-environment

Should this not rather be bundle exec bin/rake db:setup to create the database?

Furthermore, this describes the creation of the test-database, which IMHO would require to append a RAILS_ENV=test to the command.

The text was updated successfully, but these errors were encountered:

Contributor Author

m-bucher commented Jun 22, 2020

Even better would probably be to use bundle exec rake db:create db:migrate RAILS_ENV=test.
Otherwise, it will not be correctly detected by this code in foreman: https://github.com/theforeman/foreman/blob/7b333c0082231c950e61b0dbc65375cf438e73b3/lib/foreman.rb#L23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment