-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential code generation changes. #215
Comments
anschweitzer
added a commit
that referenced
this issue
Oct 31, 2023
This PR adds support for Tank modules accessed by sending HTTP polls to a Hubitat which is configured to communicate with Fibaro Smart Implant temperature sensors on the tank via Fibaro / Hubitat ZWave network. Changes: 1. New CACS, Components and enums added for Fibaro Smart Implant, Hubitat, Hubitat Tank Module and generic RESTPoller. 2. HardwareLayout has been modified: 1. Components and CACS in OtherComponents/OtherCACs can be decoded from TypeName without need to specify the decoding class. 2. A "resolve" phase has been added after loading CACs, Components and Nodes to allow validation of relationships between entities when that validation requires all CACs, Components and Nodes to have been decoded. 3. Code generation has been broken by this merge. Fixing up code generation will be addressed by #214. More code generation discussion in #215.
anschweitzer
added a commit
that referenced
this issue
Oct 31, 2023
Tank Module via HTTP/Hubitat/Fibaro (#205) This PR adds support for Tank modules accessed by sending HTTP polls to a Hubitat which is configured to communicate with Fibaro Smart Implant temperature sensors on the tank via Fibaro / Hubitat ZWave network. Changes: 1. New CACS, Components and enums added for Fibaro Smart Implant, Hubitat, Hubitat Tank Module and generic RESTPoller. 2. HardwareLayout has been modified: 1. Components and CACS in OtherComponents/OtherCACs can be decoded from TypeName without need to specify the decoding class. 2. A "resolve" phase has been added after loading CACs, Components and Nodes to allow validation of relationships between entities when that validation requires all CACs, Components and Nodes to have been decoded. 3. Code generation has been broken by this merge. Fixing up code generation will be addressed by #214. More code generation discussion in #215.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue lists changes that might simplify use of code generation. These are open for discussion and/or experimentation.
_Maker
classes in favor of from_data_class() and to_data_class() functions on the relevant class, which should require substantially fewer lines and better locality that the Maker code. We still have the option to use Makers when the simple conversion functions aren't sufficient.The text was updated successfully, but these errors were encountered: