Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Include block included/finalization status in transaction/batch storage #592

Open
jacque006 opened this issue May 24, 2021 · 0 comments
Open

Include block included/finalization status in transaction/batch storage #592

jacque006 opened this issue May 24, 2021 · 0 comments
Labels
client This PR is about implementing the client
Milestone
Public Testnet 2

Comments

@jacque006
Copy link
Collaborator

Related: #548

What's wrong

Block included (finalization) data is not included in metadata for transactions and batches

How we can solve

  • Have node track when new ETH blocks are mined and what the current block number is.
  • Update transaction and batch metadata when the current block = batch submitted block + BLOCKS_TO_FINALISE so consumers know when a transaction or batch is locked in.

Consider

  • How many confirmations do we need to consider a block mined? We currently use 1 in many places, but might be worth adding another constant to set this.
@jacque006 jacque006 added the client This PR is about implementing the client label May 24, 2021
This was referenced May 24, 2021
Closed
Merged
@jacque006 jacque006 added this to the Public Testnet 2 milestone Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
client This PR is about implementing the client
Projects
None yet
Milestone
Public Testnet 2
Development

No branches or pull requests
1 participant
@jacque006