Skip to content
This repository has been archived by the owner on Oct 5, 2022. It is now read-only.

generated gitignore is too strict #33

Open
duncdrum opened this issue Aug 6, 2021 · 0 comments · May be fixed by #34
Open

generated gitignore is too strict #33

duncdrum opened this issue Aug 6, 2021 · 0 comments · May be fixed by #34

Comments

@duncdrum
Copy link

duncdrum commented Aug 6, 2021 •
edited
Loading

When using this template the generated .gitignore contains

webpack.config.js
yarn.lock

neither file should be ignored. The first is for user modifications in combination with gen-webpack.config.js, so it makes no sense to have it ignored (while still being checked into the git tree) OOTB.

As for yarn.lock the recommendation is clearly to not have it ignored either.

While it is easy for users to manually unignore both files, it should be a simple fix to simply remove them from the .gitignore here to save everyone the hassle.

see evolvedbinary/fusion-studio#93
see eclipse-theia/theia-ide#134
@duncdrum duncdrum mentioned this issue Aug 6, 2021
Closed
duncdrum added a commit to evolvedbinary/yangster-electron that referenced this issue Aug 10, 2021
@duncdrum
fix(gitignore): add files to git
d44f76d 
close theia-ide#33
@duncdrum duncdrum linked a pull request Aug 10, 2021 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(gitignore): add files to git evolvedbinary/yangster-electron
1 participant
@duncdrum