Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests for Cassandra 4.1/trunk #544

Open
2 tasks
emerkle826 opened this issue Dec 5, 2022 · 3 comments · May be fixed by #781
Open
2 tasks

Fix failing tests for Cassandra 4.1/trunk #544

emerkle826 opened this issue Dec 5, 2022 · 3 comments · May be fixed by #781
Assignees
@rzvoncek
Labels
blocked Issues in the state 'blocked'

Comments

@emerkle826
Copy link
Collaborator

emerkle826 commented Dec 5, 2022 •
edited by sync-by-unito bot
Loading

Project board link

One of the Integration tests that uses Management API jars for testing grpc functionality has been failing for a while when run against Cassandra trunk. The test should be fixable now as part of the issue was that the available Management API jarfiles used to setup the test were not compatible with Casandra trunk at the time they started failing. The test code in question that can now be fixed is here:

https://github.com/thelastpickle/cassandra-medusa/blob/master/tests/integration/features/steps/integration_steps.py#L1381-L1399

Essentially, that code block needs to accommodate the 4.1 Management API jarfiles that are now available. These should fix the issues when testing against trunk. In the process, we probably should add Cassandra 4.1 tests as well.

Definition of done

  • Run ITs against 4.1.3 (latest at the moment) and trunk using non-local storage providers.
  • Run ITs against 4.1.latest, trunk, or whatever new releases are there using local storage provider.

┆Issue is synchronized with this Jira Story by Unito
@adejanovski adejanovski added the new Issues requiring triage label Dec 5, 2022
@adejanovski adejanovski added ready Issues in the state 'ready' labels Jan 9, 2023
@rzvoncek rzvoncek self-assigned this Sep 20, 2023
@rzvoncek rzvoncek added refactoring and removed new Issues requiring triage labels Sep 20, 2023
@rzvoncek rzvoncek mentioned this issue Sep 26, 2023
Closed
@emerkle826
Copy link
Collaborator Author

Revisiting this ticket to update some things.

  1. The test code that will need to be changed is currently here (the symlink_mgmt_api_jar function in case things change and the line num,bers get off)
  2. Since this ticket was originally created, Cassandras 4.1 (which used to be trunk) has been released, Cassandra 5.0 is in Alpha1 and Cassandra trunk is 5.1-SNAPSHOT. So the setup function above will have to handle a few more Cassandra versions
  3. As it currently stands, the Management API project does not currently work with Cassandra trunk (5.1-SNAPSHOT), and I believe it no longer works with Cassandra 5.0-alpha1. It does work with Cassandra 4.1.x, so at the very least, we can update the test setup to include that version

Also, the code in the get_mgmt_api_jars function here will need to be changed to fetch those 4.1 jarfiles.

@rzvoncek
Copy link
Contributor

Placing the jars got solved, but I'm hard stuck on running sstableloader against a 4.1.3 cluster with client-server encryption turned on. Not even Mick knows how to do this. It's veryl ikely I might need to put this issue on hold.

@rzvoncek
Copy link
Contributor

Putting this issue on hold.

In #655 I managed to add ITs for 4.1.3 and trunk, but had to exclude the local storage backend, which runs some scenarios (namely @11 and @18 at the very least) that do things that don't work.

The main thing that does not work is the sstableloader load when a client-server encryption is enabled. I've asked at ASF slack, where it seems to be a known issue, but the fix to replace the java-driver is not good enough to pursue. I had another fix, where I disabled the client-server encryption, but it didn't work anyway.

Then there is the issue that the management API currently does not work with Cassanra trunk anyway.

@adejanovski adejanovski added blocked Issues in the state 'blocked' and removed ready Issues in the state 'ready' labels Sep 28, 2023
@rzvoncek rzvoncek linked a pull request Sep 28, 2023 that will close this issue
Enable tests for 4.1.3 and trunk Cassandra #655
Closed
@adejanovski adejanovski added ready-for-review Issues in the state 'ready-for-review' and removed blocked Issues in the state 'blocked' to-groom labels Apr 8, 2024
@rzvoncek rzvoncek added blocked Issues in the state 'blocked' and removed ready-for-review Issues in the state 'ready-for-review' labels Apr 8, 2024
@rzvoncek rzvoncek linked a pull request Jun 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rzvoncek rzvoncek

Labels
blocked Issues in the state 'blocked'
Projects
None yet
Milestone
No milestone
3 participants
@emerkle826 @rzvoncek @adejanovski