Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duration has to be >= 60 seconds #109

Open
jsanda opened this issue Aug 29, 2019 · 2 comments
Open

duration has to be >= 60 seconds #109

jsanda opened this issue Aug 29, 2019 · 2 comments

Comments

@jsanda
Copy link
Contributor

jsanda commented Aug 29, 2019

I discover this while writing an integration test for my k8s operator. My test runs tlp-stress with the following args:

tlp-stress run KeyValue --duration 20s

In the logs for my tlp-stress pod, I saw:

Executing 1000000 operations with consistency level LOCAL_ONE

I confirmed that this is because HumanReadableTimeConverter.convert returns duration.toMinutes().

It is somewhat of a minor nit, but it might be worth documenting.

@rustyrazorblade
Copy link
Contributor

Good catch. We should either throw an error or allow seconds to be provided. I don't personally see much use for seconds; stress testing for 10s doesn't tell you anything, but there might be some valid cases for it around debugging like you've using there.

@jsanda
Copy link
Contributor Author

jsanda commented Oct 10, 2019

My use case was for integration tests in which I needed to verify that tlp-stress ran. Outside of that I agree that there is not much using for a duration < 60 sec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants