Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad project name detection (?) with v0.7.1 #120

Closed
d125q opened this issue Dec 17, 2020 · 2 comments · Fixed by #122
Closed

Bad project name detection (?) with v0.7.1 #120

d125q opened this issue Dec 17, 2020 · 2 comments · Fixed by #122
Assignees
Labels
bug Something isn't working

Comments

@d125q
Copy link
Contributor

d125q commented Dec 17, 2020

When I attempt to build the master branch of https://github.com/alerque/libertinus using v0.7.1 using a local fontship installation, I get an error saying

make: *** No rule to make target '.fontship/LibertinusGitSerif-Regular-subr.otf', needed by 'LibertinusGitSerif-Regular.otf'.  Stop.

My guess is that the project name is inferred to be LibertinusGit instead of Libertinus.
v0.7.0 works without any problems.
(To be honest, I only suspect this to be a fontship issue which is why I’m reporting it here, but I’m not sure.)

@alerque
Copy link
Member

alerque commented Dec 17, 2020

Given that v0.7.1 was released specifically to fix project name detection in remote CI environments like GH Actions that reduced the amount of Git meta data that was available, it's a pretty reasonable assumption that I broke local detection in the process. I'll check it out.

One thing this highlights is that it's hart to test all the various use cases manually. See #45, but at some point I need not just one but a small suite of test repos to test local & remote runners against various project layouts and source file types (SFD, UFO, Glyphs, single vs. multiple font family per repo, etc).

Additionally the possible file layouts that should be detected isn't properly documented (see #119).

@alerque
Copy link
Member

alerque commented Dec 17, 2020

Confirmed, I have this problem locally too both with system installed packages (Arch Linux) and Docker.

@alerque alerque added the bug Something isn't working label Dec 17, 2020
@alerque alerque self-assigned this Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants