refactor!: game versioned missionsInLocation, fix certain contracts when resolved, rename missionsInLocations -> missionsInLocation #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it always should have been.
|
Discussion question before it should be considered to be merged: should |
This was
linked to
issues
Jan 4, 2025
RDIL
reviewed
Jan 4, 2025
RDIL
reviewed
Jan 4, 2025
|
I think we have a scan for groups hook? |
We do, but it is named |
RDIL
reviewed
Jan 5, 2025
| "4fbfae2e-a5e7-4b79-b008-94f6cbcb13cb", | ||
| "3721e543-b5e6-4af8-a4fc-c92e9a4453bd", | ||
| "8c6daf5e-5974-4438-af20-71ff570c7ff3", | ||
| export const missionsInLocation = { |
There was a problem hiding this comment.
Does this not satisfy that?
RDIL
reviewed
Jan 5, 2025
Co-authored-by: Reece Dunham <[email protected]>
|
Sorry @ Private for that tag. Didn't even expect that. What about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #510 #505 #504
Needs testing and checking over more than twice.
Breaking Changes
controller.missionsInLocationsis nowcontroller.missionsInLocation(as it always should have been!).controller.missionsInLocationsis now split by game version.controller.addEscalationhas a new parameter:(groupContract, locationId, **gameVersion**, ...levels)(highlighted using asterisks).Also this removes some terrible hacks we've had to do. We should've always done it like this!