Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Google's OpenID configuration endpoint to fetch provider URLs (suggestion) #75

Open
chrisforrence opened this issue Feb 6, 2019 · 1 comment

Comments

@chrisforrence
Copy link

Google exposes an OpenID configuration file at the following URL:

https://accounts.google.com/.well-known/openid-configuration

I'm wondering if it would be worth it to reach out to this URL and use it to build up the getBaseAuthorizationUrl, getBaseAccessTokenUrl and getResourceOwnerDetailsUrl strings. Advantage would be having the URLs be always* accurate without needing to deploy a new version of the library (preventing #63), disadvantage would be needing to make an extra HTTP request to fetch said information.

@shadowhand
Copy link
Member

@chrisforrence that would be the correct thing to do. The reason I did not make that change was because it is a departure from how previous versions determine the remote URLs.

Happy to review a PR that makes use of it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants