-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Include SRC tests to nocodec topology tests #1035
Comments
The 997 Hz alsabat test will be fine. If SRC breaks the result is very corrupted sine wave or different playback or capture time vs. desired and alsabat will notice the frequency shift and fail it. |
If no one volunteers, I will assign it to me later this week.
I need a way to set SRC parameters. Will check with @singalsu . Need to implement that SOF CI friendly |
@fredoh9 just to be clear we only want 3 frequencies 44.1, 48 and 96K nothing in between |
It seems alsabat takes similar |
Looks not trivial to me. hehe. I know alsabat support -r parameter for targer frequency, we are already using it. int generate_sine_wave(struct bat *bat, int frames, void *buf)
{
...
sin_generator_init(&sg[c], 1.0, bat->target_freq[c], bat->rate);
''' |
Let me take back, still need to generate sine wave with 48Khz. I think easy work around, I generated 997Hz sine wave with 44.1Khz sampling rate and save to a file. I can play the file with alsabat with target frequency 48Khz. Let me try that. |
why? It's very useful to test 8/16 kHz as well. 192 as well. I would suggest 8,16, 44.1, 96, 192 <-> 48kHz |
@plbossart this is for the PR device tests for sanity check. But for the daily test I agree we do want to add of those. |
@singalsu $ arecord -Dhw:0,2 -c 2 -r 96000 -f S32_LE -vv /dev/null dmesg
mtrace
$ arecord -Dhw:0,2 -c 2 -r 8000 -f S32_LE -vv /dev/null dmesg
|
playback at 96Khz and capture 44.1Khz works. (96Khz -> 48Khz, 48Khz ->44.1Khz) |
Ranjani's kernel PR is now merged. Also I've updated the topology PR thesofproject/sof#7547 . In my own tests playback 8 - 96 kHz and capture 8 - 48 kHz with all formats worked. |
#7547 is blocked due to a CI system issue with non-48 kHz ALSA speaker test limitation. |
Is your feature request related to a problem? Please describe.
We don't have tests for SRC component. Without tests it breaks.
Describe the solution you'd like
Run twice with nocodec topologies in PR tests playback and capture to hw:0,2 with SSP2 loopback
Describe alternatives you've considered
N/A
Additional context
To get SRC to work currently need patches
The text was updated successfully, but these errors were encountered: