Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Drop Cmocka unit tests dependence on XTOS CMake files #1162

Open
singalsu opened this issue Mar 22, 2024 · 1 comment
Open

[FEATURE] Drop Cmocka unit tests dependence on XTOS CMake files #1162

singalsu opened this issue Mar 22, 2024 · 1 comment
Labels
P2 Critical bugs or normal features type:test coverage gap This requires a new test case, not just fixing one

Comments

@singalsu
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The test/cmocka/CMakeLists.txt needs an non-existing XTOS header src/arch/xtos-wrapper/include.
We can't run xtensa unit tests.

Describe the solution you'd like
Platform independent generic headers to replace XTOS header would be needed for cmocka minimum needs.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@marc-hb marc-hb added type:test coverage gap This requires a new test case, not just fixing one P2 Critical bugs or normal features labels Mar 28, 2024
@marc-hb
Copy link
Collaborator

marc-hb commented Mar 28, 2024

Thanks @singalsu for filing this! Any idea how "hard" is the dependency on XTOS headers and CMake files? Days or weeks of work?

I think it's good to have this file in in sof-test because that's where we file and triage most of our test coverage gaps but all the corresponding code is in the main sof repo and should stay there.

@marc-hb marc-hb changed the title [FEATURE] Fix for Cmocka unit tests dependence on XTOS CMake files [FEATURE] Drop Cmocka unit tests dependence on XTOS CMake files Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Critical bugs or normal features type:test coverage gap This requires a new test case, not just fixing one
Projects
None yet
Development

No branches or pull requests

2 participants