[BUG] LOGGER_MODE=none is incomplete

[plbossart]

with run-all-tests.sh:

starting test_sof-logger 
+ test_sof-logger
+ /root/sof-test/test-case/check-sof-logger.sh
/root/sof-test/test-case/check-sof-logger.sh: line 31: type: sof-logger: not found
2021-12-03 18:47:37 UTC Sub-Test: [ERROR] sof-logger Not Installed!
2021-12-03 18:47:37 UTC Sub-Test: [ERROR] Starting func_exit_handler(), exit status=1, FUNCNAME stack:
2021-12-03 18:47:37 UTC Sub-Test: [ERROR]  die()  @  /root/sof-test/case-lib/lib.sh
2021-12-03 18:47:37 UTC Sub-Test: [ERROR]  main()  @  /root/sof-test/test-case/check-sof-logger.sh:32
2021-12-03 18:47:37 UTC Sub-Test: [ERROR] Kernel check point "KERNEL_CHECKPOINT" is not properly set
2021-12-03 18:47:37 UTC Sub-Test: [ERROR] KERNEL_CHECKPOINT=
2021-12-03 18:47:37 UTC Sub-Test: [INFO] Test Result: FAIL!

2021-12-03 19:17:46 UTC Sub-Test: [INFO] Waiting a few seconds for the DSP to fully boot and then suspend
2021-12-03 19:17:50 UTC Sub-Test: [INFO] Trying to get the DMA trace log with background sof-logger ...
2021-12-03 19:17:50 UTC Sub-Test: [COMMAND] sudo /usr/local/bin/sof-logger  -t -f 3 -l  /etc/sof/sof-cnl.ldc  -o  /root/sof-test/logs/check-sof-logger/2021-12-03-13:17:43-4714/logger.data.txt  2>  /root/sof-test/logs/check-sof-logger/2021-12-03-13:17:43-4714/logger.error.txt  &
error: src hash value from version file (0x0) differ from src hash version saved in dictionary (0xa047f9db).
2021-12-03 19:17:52 UTC Sub-Test: [ERROR] timeout sof-logger returned unexpected: 22
2021-12-03 19:17:52 UTC Sub-Test: [ERROR] Starting func_exit_handler(), exit status=1, FUNCNAME stack:
2021-12-03 19:17:52 UTC Sub-Test: [ERROR]  die()  @  /root/sof-test/case-lib/lib.sh
2021-12-03 19:17:52 UTC Sub-Test: [ERROR]  run_loggers()  @  /root/sof-test/test-case/check-sof-logger.sh:92
2021-12-03 19:17:52 UTC Sub-Test: [ERROR]  main()  @  /root/sof-test/test-case/check-sof-logger.sh:174
2021-12-03 19:17:52 UTC Sub-Test: [ERROR]  main()  @  /root/sof-test/test-case/check-sof-logger.sh:230
2021-12-03 19:17:52 UTC Sub-Test: [INFO] Test Result: FAIL!

[ranj063]

Another example is:
SOF_LOGGING=none TPLG=/lib/firmware/intel/sof-tplg/sof-hda-generic-4ch.tplg ./sof-test/test-case/check-pause-resume.sh -c 10 -m playback

This test reports no errors but fails with:
declare -- cmd="journalctl_cmd --since=@1639521497"
error: src hash value from version file (0x0) differ from src hash version saved in dictionary (0x63913017).
error: src hash value from version file (0x0) differ from src hash version saved in dictionary (0x63913017).
2021-12-14 22:38:27 UTC [INFO] pkill -TERM sof-logger
2021-12-14 22:38:27 UTC [ERROR] sof-logger was already dead
2021-12-14 22:38:28 UTC [INFO] nlines=1 /root/sof-test/logs/check-pause-resume/2021-12-14-14:38:12-14617/slogger.txt
2021-12-14 22:38:28 UTC [ERROR] Empty logger trace
2021-12-14 22:38:28 UTC [INFO] Test Result: FAIL!

FYI, I may have the ldc file for the SOF firmware but SOF_LOGGER=none shoud ignore it.

[marc-hb]

I'm seeing this only now by chance. We should configure this sof-test project to automatically notify some people, at least for triage but I don't really have the time to take a github training right now so every time you file a new issue please check whether anyone has been automatically assigned or notified and if not please add some semi-random people manually, thanks! A good habit because this can happen with any other github project, not just this one.

[marc-hb]

These look like two very different issues.

The first issue happens because test-case/check-sof-logger.sh unsurprisingly invokes sof-logger differently from other tests. This test could skip itself when SOF_LOGGING=none but to be honest why run a logger test with SOF_LOGGING=none in the first place? Does not seem to make a lot of sense. So low priority IMHO. EDIT: filed in #843

The second and different issue looks more annoying, let me have a look at it.

[marc-hb]

@ranj063 I cannot reproduce the second issue.

$ ./test-case/check-pause-resume.sh -c 10 -m playback
...
error: src hash value from version file (0xe3221506) differ from src hash version saved in dictionary (0xb0c5effc).
error: src hash value from version file (0xe3221506) differ from src hash version saved in dictionary (0xb0c5effc).
2022-01-21 19:19:04 UTC [INFO] pkill -TERM sof-logger
2022-01-21 19:19:04 UTC [ERROR] sof-logger was already dead
2022-01-21 19:19:05 UTC [INFO] nlines=1 sof-test/logs/check-pause-resume/2022-01-21-11:18:10-12385/slogger.txt
2022-01-21 19:19:05 UTC [ERROR] Empty logger trace
2022-01-21 19:19:05 UTC [INFO] Test Result: FAIL!

$ SOF_LOGGING=none ./test-case/check-pause-resume.sh -c 10 -m playback
2022-01-21 19:19:40 UTC [INFO] SOF logs collection globally disabled by SOF_LOGGING=none
...
declare -- cmd="journalctl_cmd --since=@1642792803"
2022-01-21 19:20:10 UTC [INFO] Test Result: PASS!

FYI, I may have the ldc file for the SOF firmware but SOF_LOGGER=none shoud ignore it.

It's SOF_LOGGING, maybe you made a typo?

[marc-hb]

The first issue is filed in

• [FEATURE] IPC4: check-sof-logger.sh should not proceed #843.

I cannot reproduce the second issue.

We also have

• [FEATURE] sof-test should run without DMA trace - only etrace #726

If no objection I will close this one as duplicate because the other issues are more specific / better defined.

[plbossart]

I think this is no longer relevant, closing.