Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zipformer's online feature. #35

Open
ghjdegithub opened this issue Oct 22, 2024 · 9 comments
Open

Add zipformer's online feature. #35

ghjdegithub opened this issue Oct 22, 2024 · 9 comments
Labels
feature New feature or request

Comments

@ghjdegithub
Copy link
Contributor

No description provided.

@thewh1teagle
Copy link
Owner

Can you provide example from sherpa-onnx repository? I don't know what's the online capabilities of sherpa-onnx with zipformer.

@ghjdegithub
Copy link
Contributor Author

Can you provide example from sherpa-onnx repository? I don't know what's the online capabilities of sherpa-onnx with zipformer.

I'm referring to the example of golang, and I don't recommend referring to the example of python, python wraps another layer on top of ffi

@ghjdegithub
Copy link
Contributor Author

image

When I submit it, you can take a look at it then

@ghjdegithub
Copy link
Contributor Author

image

I found that each of your granularities is too large, and there are a lot of unsafes, so you need to control the granularity, narrow the scope of unsafes a little bit, and pack them into a proper structure.

@ghjdegithub
Copy link
Contributor Author

@thewh1teagle
I've committed, and reorganized the code to make the structure clearer

@ghjdegithub
Copy link
Contributor Author

#43 8964974 18224b0 084d09f

@thewh1teagle
Copy link
Owner

I've committed, and reorganized the code to make the structure clearer

I wrote many comments in the review of the PR
Did you see them?

@ghjdegithub
Copy link
Contributor Author

I've committed, and reorganized the code to make the structure clearer

I wrote many comments in the review of the PR Did you see them?

If you take a screenshot, I'll take a look, and I'll see if I see your comment

@thewh1teagle
Copy link
Owner

I've committed, and reorganized the code to make the structure clearer

I wrote many comments in the review of the PR Did you see them?

If you take a screenshot, I'll take a look, and I'll see if I see your comment

In this link
#43
You can see the review comments right there

@thewh1teagle thewh1teagle added the feature New feature or request label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants