This repository has been archived by the owner on Aug 14, 2023. It is now read-only.
Graceful shutdown of buffers #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Not sure if you're still interested in maintaining this library but I came across it and it seemed to fit my needs very nicely.
Motivation
Closes #10
It would be nice if we didn't drop events on e.g. restarts.
Proposed solution
I added a
terminateGenServer callback that invokes flush on each buffer. Test included.In order to make a couple tests not explode when their
terminatecallbacks were run, I ended up creating agraceful_shutdownflag which is on by default, but can be disabled for those tests. I'm not super happy with that solution, but I couldn't getMox.stubto work for those tests either.If you have a better testing strategy, I'd be happy to investigate.