Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missile Code Refactor Needed #914

Open
thkruz opened this issue Aug 16, 2024 · 0 comments
Open

Missile Code Refactor Needed #914

thkruz opened this issue Aug 16, 2024 · 0 comments
Assignees
Milestone

Comments

@thkruz
Copy link
Owner

thkruz commented Aug 16, 2024

User Story

  • As a developer
  • I want to refactor the missile creation logic into a well-structured class
  • So that the code is easier to maintain and bugs related to input stacking are resolved

Acceptance Criteria

  • The missile creation logic is encapsulated within a class.
  • The class should support all existing functionality, including the ability to handle various input types.
  • The class design should be modular, allowing for future extensions or modifications with minimal impact on existing code.
  • Refactoring should resolve known bugs related to input stacking.
  • Unit tests should be updated or created to ensure the class operates as expected without introducing new issues.

Commentary

  • The current implementation is prone to bugs when different inputs are stacked on top of each other, making it difficult to maintain.
  • The refactoring should not only resolve these bugs but also improve the overall structure of the code for future extensions or modifications.
  • Consider implementing design patterns such as Builder or Factory to enhance flexibility and robustness.
  • Update or create unit tests to ensure the new class operates as expected without introducing new issues.
@thkruz thkruz added this to the Backlog milestone Aug 16, 2024
@thkruz thkruz self-assigned this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant