From e7f6f98c638094beba2cd68b1ae7e329714e7830 Mon Sep 17 00:00:00 2001
From: Brendan O'Connell <brendan@openbookpublishers.com>
Date: Fri, 31 May 2024 17:10:57 +0200
Subject: [PATCH] Reordered WorkStatus enum in mod.rs, made publication_date
 and withdrawn_date required in View for relevant work_status, fixed Thoth
 error message for work_active_publication_date_check

---
 thoth-api/src/model/work/mod.rs     |  6 +++---
 thoth-app/src/component/new_work.rs | 16 +++++++++-------
 thoth-app/src/component/work.rs     | 18 +++++++++++-------
 thoth-errors/src/database_errors.rs |  2 +-
 4 files changed, 24 insertions(+), 18 deletions(-)

diff --git a/thoth-api/src/model/work/mod.rs b/thoth-api/src/model/work/mod.rs
index c349fc4da..63ef3d4d3 100644
--- a/thoth-api/src/model/work/mod.rs
+++ b/thoth-api/src/model/work/mod.rs
@@ -54,15 +54,15 @@ pub enum WorkType {
 #[serde(rename_all = "SCREAMING_SNAKE_CASE")]
 #[strum(serialize_all = "title_case")]
 pub enum WorkStatus {
-    Cancelled,
     #[default]
     Forthcoming,
-    #[cfg_attr(feature = "backend", db_rename = "postponed-indefinitely")]
-    PostponedIndefinitely,
     Active,
     #[cfg_attr(feature = "backend", db_rename = "withdrawn-from-sale")]
     WithdrawnFromSale,
     Superseded,
+    #[cfg_attr(feature = "backend", db_rename = "postponed-indefinitely")]
+    PostponedIndefinitely,
+    Cancelled,
 }
 
 #[cfg_attr(
diff --git a/thoth-app/src/component/new_work.rs b/thoth-app/src/component/new_work.rs
index 61e68fa4a..95fa674a5 100644
--- a/thoth-app/src/component/new_work.rs
+++ b/thoth-app/src/component/new_work.rs
@@ -290,7 +290,7 @@ impl Component for NewWorkComponent {
                     self.work.page_interval = None;
                 }
                 if self.work.work_status != WorkStatus::WithdrawnFromSale &&
-                self.work.work_status != WorkStatus::WithdrawnFromSale
+                self.work.work_status != WorkStatus::Superseded
                 {
                     self.work.withdrawn_date = None;
                 }
@@ -458,10 +458,12 @@ impl Component for NewWorkComponent {
         // Grey out chapter-specific or "book"-specific fields
         // based on currently selected work type.
         let is_chapter = self.work.work_type == WorkType::BookChapter;
-        let is_not_withdrawn = self.work.work_status
-            != WorkStatus::WithdrawnFromSale;
-        let is_active = self.work.work_status
-            == WorkStatus::Active;
+        let is_not_withdrawn_or_superseded = self.work.work_status
+            != WorkStatus::WithdrawnFromSale && self.work.work_status != WorkStatus::Superseded;
+        let is_active_withdrawn_or_superseded = self.work.work_status
+            == WorkStatus::Active || 
+            self.work.work_status == WorkStatus::WithdrawnFromSale || 
+            self.work.work_status == WorkStatus::Superseded;
         html! {
             <>
                 <nav class="level">
@@ -528,14 +530,14 @@ impl Component for NewWorkComponent {
                         label = "Publication Date"
                         value={ self.work.publication_date.clone() }
                         oninput={ ctx.link().callback(|e: InputEvent| Msg::ChangeDate(e.to_value())) }
-                        required={ is_active }
+                        required={ is_active_withdrawn_or_superseded }
                     />
                     <FormDateInput
                         label = "Withdrawn Date"
                         value={ self.work.withdrawn_date.clone() }
                         oninput={ ctx.link().callback(|e: InputEvent| Msg::ChangeWithdrawnDate(e.to_value())) }
                         required = true
-                        deactivated={ is_not_withdrawn }
+                        deactivated={ is_not_withdrawn_or_superseded }
                     />
                     <FormTextInput
                         label = "Place of Publication"
diff --git a/thoth-app/src/component/work.rs b/thoth-app/src/component/work.rs
index 5af084ce3..ba0731e9f 100644
--- a/thoth-app/src/component/work.rs
+++ b/thoth-app/src/component/work.rs
@@ -305,7 +305,8 @@ impl Component for WorkComponent {
                     self.work.last_page = None;
                     self.work.page_interval = None;
                 }
-                if self.work.work_status != WorkStatus::WithdrawnFromSale
+                if self.work.work_status != WorkStatus::WithdrawnFromSale && 
+                    self.work.work_status != WorkStatus::Superseded
                 {
                     self.work.withdrawn_date = None;
                 }
@@ -577,10 +578,13 @@ impl Component for WorkComponent {
                 // Grey out chapter-specific or "book"-specific fields
                 // based on currently selected work type.
                 let is_chapter = self.work.work_type == WorkType::BookChapter;
-                let is_not_withdrawn = self.work.work_status
-                    != WorkStatus::WithdrawnFromSale;
-                let is_active = self.work.work_status
-                    == WorkStatus::Active;
+                let is_not_withdrawn_or_superseded = 
+                    self.work.work_status != WorkStatus::WithdrawnFromSale &&
+                    self.work.work_status != WorkStatus::Superseded;
+                let is_active_withdrawn_or_superseded = 
+                    self.work.work_status == WorkStatus::Active || 
+                    self.work.work_status == WorkStatus::WithdrawnFromSale || 
+                    self.work.work_status == WorkStatus::Superseded;
                 html! {
                     <>
                         <nav class="level">
@@ -655,14 +659,14 @@ impl Component for WorkComponent {
                                 label = "Publication Date"
                                 value={ self.work.publication_date.clone() }
                                 oninput={ ctx.link().callback(|e: InputEvent| Msg::ChangeDate(e.to_value())) }
-                                required = { is_active }
+                                required = { is_active_withdrawn_or_superseded }
                             />
                             <FormDateInput
                                 label = "Withdrawn Date"
                                 value={ self.work.withdrawn_date.clone() }
                                 oninput={ ctx.link().callback(|e: InputEvent| Msg::ChangeWithdrawnDate(e.to_value())) }
                                 required = true
-                                deactivated={ is_not_withdrawn }
+                                deactivated={ is_not_withdrawn_or_superseded }
                                 />
                             <FormTextInput
                                 label = "Place of Publication"
diff --git a/thoth-errors/src/database_errors.rs b/thoth-errors/src/database_errors.rs
index 482d7f070..2c5ac32bf 100644
--- a/thoth-errors/src/database_errors.rs
+++ b/thoth-errors/src/database_errors.rs
@@ -121,7 +121,7 @@ static DATABASE_CONSTRAINT_ERRORS: Map<&'static str, &'static str> = phf_map! {
     "subject_subject_code_check" => "Subject codes must not be an empty string.",
     "subject_subject_ordinal_check" => "A subject ordinal number must be greater than 0.",
     "work_active_withdrawn_date_check" => "Withdrawn Date can only be set for a withdrawn from sale or superseded Work.",
-    "work_active_publication_date_check" => "Active works must have a publication date.",
+    "work_active_publication_date_check" => "Active, superseded and withdrawn from sale works must have a publication date.",
     "work_audio_count_check" => "An audio count must be greater than 0.",
     "work_bibliography_note_check" => "Bibliography note must not be an empty string.",
     "work_chapter_no_edition" => "Chapters must not have an edition number.",