Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local development integration with toolbox for Python 3.9 and RHEL9 #341

Closed
6 tasks
goern opened this issue Oct 19, 2021 · 8 comments
Closed
6 tasks

Local development integration with toolbox for Python 3.9 and RHEL9 #341

goern opened this issue Oct 19, 2021 · 8 comments
Assignees
Labels
kind/key-result This is a Key Result we want to achieve. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@goern
Copy link
Member

goern commented Oct 19, 2021

A suggested edit of this issue's description that expands it and incorporates #342:

Local development integration with toolbox for Python 3.9 and RHEL9

Based on the Jupyter Notebook images we provide, we want to provide toolbox enabled images that can be used to run a jupyter notebook on a local laptop.

This is a migration step during bringing your own notebooks to OpenDataHub (ODH).

High-level Goals

Create a Kebechet-maintained toolbox container image that could be used in a local development environment as an extension/a base for all Thoth ODH images.

The image would contribute to a more gentle and complete developer workflow by allowing a developer to:

  • kickstart local development quickly and without effort: just use the toolbox image to work on your code/notebooks without having to install devel stacks and worry about dependencies
  • the resulting local dev environment provides Thoth's features out of the box
  • easily transition to and from hosted and local development environments: the same tools and features are available locally and remotely

Describe the solution you'd like

As a pre-requisite, as the upcoming RHEL9 will use Python 3.9, we need to prepare our toolchain for this:

  • s2i-thoth and thoth-ops-infra need to be updated
  • pytest and mypy toolchain needs to be provided for py39
  • advises are available for the 3.9 stack

With that in place, the toolbox images should aim at minimal drift.

The top priority is user experience, but the guiding principle is to use/mimic the hosted/online counterparts' content and workflow as much as possible.

Additional context

This is a Key Result we want to deliver in the first half of 2022.

Acceptance Criteria

  • all the Thoth toolchain works with Python 3.9 and RHEL9
  • toolbox container images are provided on quay.io
  • published sample notebooks/applications are verified to work with the tools in a local laptop
    • automated testing ensures that these continue to work
  • a demo is recorded and published
  • a tutorial is published for developers to get started

See also

@goern goern added area/byon kind/key-result This is a Key Result we want to achieve. labels Oct 19, 2021
@sesheta sesheta added the needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. label Oct 19, 2021
@goern goern added this to the OKR review Q4 2022 milestone Oct 19, 2021
@codificat
Copy link
Member

/assign @codificat

@goern
Copy link
Member Author

goern commented Oct 21, 2021

/priority important-soon
/triage accepted

@sesheta sesheta added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. labels Oct 21, 2021
@codificat
Copy link
Member

/milestone OKR review Q1 2022

@goern goern changed the title create toolbox integration for Bring your own Notebooks Local development integration with toolbox for Python 3.9 and RHEL9 Dec 9, 2021
@goern
Copy link
Member Author

goern commented Feb 22, 2022

@fridex @codificat shall we push this back to the backlog?

@sesheta
Copy link
Member

sesheta commented May 23, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 23, 2022
@sesheta
Copy link
Member

sesheta commented Jun 22, 2022

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 22, 2022
@sesheta
Copy link
Member

sesheta commented Jul 22, 2022

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta sesheta closed this as completed Jul 22, 2022
@sesheta
Copy link
Member

sesheta commented Jul 22, 2022

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/key-result This is a Key Result we want to achieve. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants