Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

thoth metrics AssertionError: Repository(full_name="thoth-station/s2i-python-container") #552

Open
2 tasks
xtuchyna opened this issue Mar 15, 2022 · 4 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/observability Categorizes an issue or PR as relevant to SIG Observability triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@xtuchyna
Copy link
Member

xtuchyna commented Mar 15, 2022

Bug description

When using -t option on thoth-station/s2i-python-container repo, Assertion error occurs

Expected behavior

AssertionError should not occur within code

LOGS

INFO:aicoe-src-ops-metrics:#### Launching thoth data analysis ####
INFO:aicoe-src-ops-metrics:Creating metrics for repository thoth-station/s2i-python-container
Traceback (most recent call last):
  File "srcopsmetrics/cli.py", line 219, in <module>
    cli(auto_envvar_prefix="MI")
  File "/opt/app-root/lib64/python3.8/site-packages/click/core.py", line 1128, in __call__
    return self.main(*args, **kwargs)
  File "/opt/app-root/lib64/python3.8/site-packages/click/core.py", line 1053, in main
    rv = self.invoke(ctx)
  File "/opt/app-root/lib64/python3.8/site-packages/click/core.py", line 1395, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/app-root/lib64/python3.8/site-packages/click/core.py", line 754, in invoke
    return __callback(*args, **kwargs)
  File "srcopsmetrics/cli.py", line 191, in cli
    kebechet_metrics = KebechetMetrics(repository=repo, day=yesterday, is_local=is_local)
  File "/opt/app-root/src/srcopsmetrics/kebechet_metrics.py", line 70, in __init__
    self.prs = PullRequest(gh_repo).load_previous_knowledge(is_local=is_local)
  File "/opt/app-root/src/srcopsmetrics/entities/interface.py", line 59, in __init__
    self.repository = github_handling.connect_to_source(repository_name)
  File "/opt/app-root/src/srcopsmetrics/github_handling.py", line 92, in _wrapper
    return original_funcion(*args, **kwargs)
  File "/opt/app-root/src/srcopsmetrics/github_handling.py", line 109, in connect_to_source
    return get_github_object().get_repo(repository_name)
  File "/opt/app-root/lib64/python3.8/site-packages/github/MainClass.py", line 323, in get_repo
    assert isinstance(full_name_or_id, (str, int)), full_name_or_id
AssertionError: Repository(full_name="thoth-station/s2i-python-container")

Acceptance Criteria

  • verify the error exists and still relevant
  • Fix the assertionerror if not handled.
@xtuchyna xtuchyna added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. labels Mar 15, 2022
@goern
Copy link
Member

goern commented Apr 4, 2022

is this still relevant?

@goern
Copy link
Member

goern commented May 16, 2022

/priority backlog

@sesheta sesheta added the priority/backlog Higher priority than priority/awaiting-more-evidence. label May 16, 2022
@goern goern added the sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. label Aug 11, 2022
@Gkrumbach07 Gkrumbach07 added sig/observability Categorizes an issue or PR as relevant to SIG Observability and removed sig/user-experience Issues or PRs related to the User Experience of our Services, Tools, and Libraries. labels Aug 16, 2022
@codificat
Copy link
Member

/triage needs-information

@sesheta sesheta added the triage/needs-information Indicates an issue needs more information in order to work on it. label Sep 19, 2022
@harshad16 harshad16 moved this to New in SIG-DevSecOps Sep 22, 2022
@codificat codificat moved this to 🆕 New in Planning Board Sep 26, 2022
@harshad16
Copy link
Member

/triage accepted

@sesheta sesheta added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Oct 27, 2022
@harshad16 harshad16 moved this from 🆕 New to 🔖 Next in Planning Board Oct 27, 2022
@harshad16 harshad16 removed triage/needs-information Indicates an issue needs more information in order to work on it. needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. labels Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/observability Categorizes an issue or PR as relevant to SIG Observability triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: 🔖 Next
Status: 🆕 New
Development

No branches or pull requests

6 participants