Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kebechet github installation table managers columns are all false #2165

Closed
pacospace opened this issue Nov 29, 2021 · 4 comments · Fixed by #2191
Closed

Kebechet github installation table managers columns are all false #2165

pacospace opened this issue Nov 29, 2021 · 4 comments · Fixed by #2191
Assignees
@KPostOffice
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@pacospace
Copy link
Contributor

Describe the bug
Kebechet github installation table managers are all false

To Reproduce
Steps to reproduce the behavior:

  1. pgweb and check Kebechet GitHubInstallation table

Expected behavior
managers are updated together with software stacks used for each repo

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Related-To: thoth-station/core#322
@pacospace pacospace added the kind/bug Categorizes issue or PR as related to a bug. label Nov 29, 2021
@sesheta sesheta added the needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. label Nov 29, 2021
@pacospace pacospace changed the title Kebechet github installation table managers are all false Kebechet github installation table managers columns are all false Nov 29, 2021
@pacospace
Copy link
Contributor Author

/assign @KPostOffice

@pacospace pacospace mentioned this issue Dec 1, 2021
Closed
2 tasks
@harshad16
Copy link
Member

/priority important-soon
/triage accepted

@sesheta sesheta added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. labels Dec 7, 2021
@KPostOffice
Copy link
Member

/lifecycle active

@sesheta sesheta added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Dec 14, 2021
@KPostOffice
Copy link
Member

KPostOffice commented Dec 14, 2021 •
edited
Loading

The issue is pretty simple actually. The update-keb-installation workflow step was only enabled in the test overlay to start and we never added it to the base overlay so it is not being updated in production or stage.

See here:

thoth-application/kebechet/overlays/test/kebechet.yaml

Line 115 in 4848c53

- name: "kebechet-webhook-run"

I'll add it to the base overlay. Hopefully this will fix the issue

@KPostOffice KPostOffice mentioned this issue Dec 14, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KPostOffice KPostOffice

Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add keb-update step to base template KPostOffice/thoth-application
4 participants
@harshad16 @KPostOffice @pacospace @sesheta