Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required pre-commit configuration and module update #2508

Closed
1 task
xtuchyna opened this issue Apr 7, 2022 · 7 comments
Closed
1 task

Required pre-commit configuration and module update #2508

xtuchyna opened this issue Apr 7, 2022 · 7 comments
Labels
needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. sig/devsecops Categorizes an issue or PR as relevant to SIG DevSecOps. triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@xtuchyna
Copy link
Member

xtuchyna commented Apr 7, 2022

Problem
For a repository to be compatible with CI pipeline, the tag of the used pre-commit image needs to be updated in prow config file.
On top of that, it is also useful to update pre-commit configuration alone along with the module update itself.

Related to thoth-station/common#1250 (comment)
@harshad16

Steps

  1. Change tags to the v0.14.3 version for both pre-commit and pytest images in .prow.yaml file
    example 1: https://github.com/thoth-station/mi/blob/685ca548a0095f6c6fe51c1e6ba10ee68b18dd3d/.prow.yaml#L9
    example 2: https://github.com/thoth-station/mi/blob/685ca548a0095f6c6fe51c1e6ba10ee68b18dd3d/.prow.yaml#L28

  2. Update pre-commit related configuration

$ pipenv install pre-commit==2.15.0
$ pre-commit autoupdate

Acceptance Criteria

  • all CI tests for the fixing PR should pass and PR is automatically merged

Linked epics / issues
thoth-station/mi-scheduler#221
thoth-station/mi#557
thoth-station/storages#2599
https://github.com/thoth-station/common/pull/1250/files

@sesheta
Copy link
Member

sesheta commented Apr 7, 2022

@xtuchyna: This issue is currently awaiting triage.
One of the @thoth-station/devsops will take care of the issue, and will accept the issue by applying the
triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta added the needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. label Apr 7, 2022
@xtuchyna
Copy link
Member Author

xtuchyna commented Apr 7, 2022

@thoth-station/devs

@goern
Copy link
Member

goern commented Apr 7, 2022

@mayaCostantini isnt 1. solved by a bot?

@mayaCostantini
Copy link
Contributor

mayaCostantini commented Apr 7, 2022

Not yet but we could integrate this into aicoe-ci and trigger checks for more recent image versions for pre-commit and pytest on a pull request for example as we already do for .aicoe-ci.yaml base image updates.

@codificat
Copy link
Member

It's unclear to me what the goal/request for this issue would be.

Is it just to raise awareness of the need to update versions across the repos? If so, that might be addressed by some documentation, e.g. in the template project where the pre-commit template is provided.

Or is it a feature request to implement automated updates? If so, then maybe this belongs to the aicoe-ci repo instead?

/triage needs-information
/sig devsecops

@sesheta sesheta added triage/needs-information Indicates an issue needs more information in order to work on it. sig/devsecops Categorizes an issue or PR as relevant to SIG DevSecOps. labels Apr 27, 2022
@sesheta
Copy link
Member

sesheta commented Jul 26, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2022
@xtuchyna
Copy link
Member Author

xtuchyna commented Aug 1, 2022

@codificat The goal was that this would be the tracking issue for similar problems. I think that currently every active repo should have this matter already solved, so we can close this

It's unclear to me what the goal/request for this issue would be.

Is it just to raise awareness of the need to update versions across the repos? If so, that might be addressed by some documentation, e.g. in the template project where the pre-commit template is provided.

Or is it a feature request to implement automated updates? If so, then maybe this belongs to the aicoe-ci repo instead?

/triage needs-information /sig devsecops

@xtuchyna xtuchyna closed this as completed Aug 1, 2022
@harshad16 harshad16 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 9, 2022
@harshad16 harshad16 moved this to Completed in SIG-DevSecOps Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Indicates an issue or PR lacks a `triage/...` label and requires one. sig/devsecops Categorizes an issue or PR as relevant to SIG DevSecOps. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
No open projects
Status: Done
Development

No branches or pull requests

6 participants