-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Required pre-commit
configuration and module update
#2508
Comments
@xtuchyna: This issue is currently awaiting triage. The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@thoth-station/devs |
@mayaCostantini isnt 1. solved by a bot? |
Not yet but we could integrate this into |
It's unclear to me what the goal/request for this issue would be. Is it just to raise awareness of the need to update versions across the repos? If so, that might be addressed by some documentation, e.g. in the template project where the pre-commit template is provided. Or is it a feature request to implement automated updates? If so, then maybe this belongs to the /triage needs-information |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
@codificat The goal was that this would be the tracking issue for similar problems. I think that currently every active repo should have this matter already solved, so we can close this
|
Problem
For a repository to be compatible with CI pipeline, the tag of the used
pre-commit
image needs to be updated in prow config file.On top of that, it is also useful to update pre-commit configuration alone along with the module update itself.
Related to thoth-station/common#1250 (comment)
@harshad16
Steps
Change tags to the
v0.14.3
version for bothpre-commit
andpytest
images in.prow.yaml
fileexample 1: https://github.com/thoth-station/mi/blob/685ca548a0095f6c6fe51c1e6ba10ee68b18dd3d/.prow.yaml#L9
example 2: https://github.com/thoth-station/mi/blob/685ca548a0095f6c6fe51c1e6ba10ee68b18dd3d/.prow.yaml#L28
Update pre-commit related configuration
Acceptance Criteria
Linked epics / issues
thoth-station/mi-scheduler#221
thoth-station/mi#557
thoth-station/storages#2599
https://github.com/thoth-station/common/pull/1250/files
The text was updated successfully, but these errors were encountered: