Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make superglue's gemspec more conservative #46

Closed
jho406 opened this issue Apr 15, 2024 · 1 comment
Closed

Make superglue's gemspec more conservative #46

jho406 opened this issue Apr 15, 2024 · 1 comment

Comments

@jho406
Copy link
Collaborator

jho406 commented Apr 15, 2024

I think making superglue’s gemspec a bit more conservative might make sense. Right now it uses.

  s.add_dependency "actionpack", ">= 7.0.0"
  s.add_development_dependency "activerecord", ">= 7.0"

Which says that it works with all future version of Rails. This isn’t 100% true as there’s a few monkey patches in `superglue_rails` that may not be compatible with future Rails versions.

We could be a bit more explicit and twiddle-wakka the versions.

@jho406 jho406 added this to Superglue Jun 24, 2024
@jho406 jho406 moved this to Needs planning in Superglue Jun 24, 2024
@jho406
Copy link
Collaborator Author

jho406 commented Jan 4, 2025

This is completed.

@jho406 jho406 closed this as completed Jan 4, 2025
@github-project-automation github-project-automation bot moved this from Needs planning to Done in Superglue Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant