Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Suspenders fail if running with an unsupported Rails version #1083

Open
thiagoa opened this issue Oct 1, 2021 · 1 comment
Open

Make Suspenders fail if running with an unsupported Rails version #1083

thiagoa opened this issue Oct 1, 2021 · 1 comment
Labels
Enhancement Features we're considering adding

Comments

@thiagoa
Copy link
Contributor

thiagoa commented Oct 1, 2021

The suspenders command does not fail when accidentally picking up an unsupported Rails version, which may lead to very strange errors. I had a problem with it picking up Rails 6.1 (actually, Rails 6.1 was uninstalled but it picked up railties 6.1.4.1, which was still installed), so to fix it I installed Rails 6.0 and ran suspenders with the following command:

suspenders _6.0.4.1_ my-app
@stevepolitodesign stevepolitodesign added the Enhancement Features we're considering adding label May 17, 2024
@stevepolitodesign
Copy link
Contributor

Although we no longer have a system executable, we should still account for this in the application template. We already do this for Node version:

if node_not_installed? || node_version_unsupported?
message = <<~ERROR
=== Node version unsupported ===
Suspenders requires Node >= 20.0.0
ERROR
fail Rails::Generators::Error, message
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Features we're considering adding
Projects
None yet
Development

No branches or pull requests

2 participants