Allow "Build Now" when disable_admin_ui is enabled

[tcwitte]

On my build server I've disabled "dangerous" actions with disable_admin_ui. However, this also disables the "Build Now" button. I want to allow that because it's useful and not dangerous.

What do you think about this? I can contribute code if I know what would be accepted. Locally I've changed the code to always allow "Build Now" even when disable_admin_ui is true.

[bguthrie]

I debated whether or not to split the "build now" permission out and ultimately decided against it because it seemed like it was dangerous "enough" - if you're hosting a CC.rb instance publicly, you don't necessarily want people to be able to spam that button, and CC.rb doesn't provide any kind of authentication or access control out of the box.

Any other strong opinions?

[tcwitte]

It's a way to interact with CC.rb, true. In my reasoning I made a distinction between actions that can make the build server unreliable (removing and altering projects, stopping builders) and actions that don't (Build now, starting builders). The reason I like to provide the users of the build server access to "Build Now" is that sometimes random build failures occur (some tests involve Selenium).

Also, only authorized people can access the build server in my case. It's accessed by VPN.

An alternative could be to have two configuration options: one for making the CC.rb interface read-only and one for disabling the administrative functions (i.e. altering projects and starting/stopping builders)?

[tcwitte]

What's your idea about having two configuration options? (one to make the interface completely read-only and one to disable the administrative functions excluding build now) If you don't like it that's ok. It's just that I'd like to know before putting time in a pull request.