Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data race in GateIO #1632

Open
thrasher- opened this issue Aug 26, 2024 · 0 comments
Open

Data race in GateIO #1632

thrasher- opened this issue Aug 26, 2024 · 0 comments
Labels
low priority This enhancement or update will be implemented at a later date.

Comments

@thrasher-
Copy link
Collaborator

thrasher- commented Aug 26, 2024

New Issue

From: https://github.com/thrasher-/gocryptotrader/actions/runs/10553362758/job/29233542062#step:10:3152

Context

WARNING: DATA RACE
Write at 0x00000188d990 by goroutine 94:
  github.com/thrasher-corp/gocryptotrader/currency.(*PairsManager).Load()
      /home/runner/work/gocryptotrader/gocryptotrader/currency/manager.go:452 +0x3d0
  github.com/thrasher-corp/gocryptotrader/internal/testing/exchange.UpdatePairsOnce()
      /home/runner/work/gocryptotrader/gocryptotrader/internal/testing/exchange/exchange.go:226 +0x1da
  github.com/thrasher-corp/gocryptotrader/exchanges/gateio.getPair()
      /home/runner/work/gocryptotrader/gocryptotrader/exchanges/gateio/gateio_test.go:3467 +0x2b6
  github.com/thrasher-corp/gocryptotrader/exchanges/gateio.TestGetMarginSupportedCurrencyPair()
      /home/runner/work/gocryptotrader/gocryptotrader/exchanges/gateio/gateio_test.go:966 +0x54
  testing.tRunner()
      /opt/hostedtoolcache/go/1.23.0/x64/src/testing/testing.go:1690 +0x226
  testing.(*T).Run.gowrap1()
      /opt/hostedtoolcache/go/1.23.0/x64/src/testing/testing.go:1743 +0x44

Previous read at 0x00000188d990 by goroutine 210:
  github.com/thrasher-corp/gocryptotrader/exchanges.(*Base).ValidateKline()
      /home/runner/work/gocryptotrader/gocryptotrader/exchanges/exchange.go:1185 +0x1b0
  github.com/thrasher-corp/gocryptotrader/exchanges.(*Base).GetKlineExtendedRequest()
      /home/runner/work/gocryptotrader/gocryptotrader/exchanges/exchange.go:1611 +0x32c
  github.com/thrasher-corp/gocryptotrader/exchanges/gateio.(*Gateio).GetHistoricCandlesExtended()
      /home/runner/work/gocryptotrader/gocryptotrader/exchanges/gateio/gateio_wrapper.go:1935 +0x193
  github.com/thrasher-corp/gocryptotrader/exchanges/gateio.TestGetHistoricCandlesExtended()
      /home/runner/work/gocryptotrader/gocryptotrader/exchanges/gateio/gateio_test.go:2502 +0x1ed
  testing.tRunner()
      /opt/hostedtoolcache/go/1.23.0/x64/src/testing/testing.go:1690 +0x226
  testing.(*T).Run.gowrap1()
      /opt/hostedtoolcache/go/1.23.0/x64/src/testing/testing.go:1743 +0x44

Goroutine 94 (running) created at:
  testing.(*T).Run()
      /opt/hostedtoolcache/go/1.23.0/x64/src/testing/testing.go:1743 +0x825
  testing.runTests.func1()
      /opt/hostedtoolcache/go/1.23.0/x64/src/testing/testing.go:2168 +0x85
  testing.tRunner()
      /opt/hostedtoolcache/go/1.23.0/x64/src/testing/testing.go:1690 +0x226
  testing.runTests()
      /opt/hostedtoolcache/go/1.23.0/x64/src/testing/testing.go:2166 +0x8be
  testing.(*M).Run()
      /opt/hostedtoolcache/go/1.23.0/x64/src/testing/testing.go:2034 +0xf17
  github.com/thrasher-corp/gocryptotrader/exchanges/gateio.TestMain()
      /home/runner/work/gocryptotrader/gocryptotrader/exchanges/gateio/gateio_test.go:63 +0x9c4
  main.main()
      _testmain.go:595 +0x171

Goroutine 210 (running) created at:
  testing.(*T).Run()
      /opt/hostedtoolcache/go/1.23.0/x64/src/testing/testing.go:1743 +0x825
  testing.runTests.func1()
      /opt/hostedtoolcache/go/1.23.0/x64/src/testing/testing.go:2168 +0x85
  testing.tRunner()
      /opt/hostedtoolcache/go/1.23.0/x64/src/testing/testing.go:1690 +0x226
  testing.runTests()
      /opt/hostedtoolcache/go/1.23.0/x64/src/testing/testing.go:2166 +0x8be
  testing.(*M).Run()
      /opt/hostedtoolcache/go/1.23.0/x64/src/testing/testing.go:2034 +0xf17
  github.com/thrasher-corp/gocryptotrader/exchanges/gateio.TestMain()
      /home/runner/work/gocryptotrader/gocryptotrader/exchanges/gateio/gateio_test.go:63 +0x9c4
  main.main()
      _testmain.go:595 +0x171
==================
--- FAIL: TestGetFuturesOrderbook (4.86s)
    testing.go:1399: race detected during execution of test
--- FAIL: TestGetSingleContract (4.91s)
    testing.go:1399: race detected during execution of test
--- FAIL: TestGetMarginSupportedCurrencyPair (5.00s)
    testing.go:1399: race detected during execution of test
--- FAIL: TestGetHistoricCandlesExtended (3.64s)
    testing.go:1399: race detected during execution of test
@thrasher- thrasher- added the low priority This enhancement or update will be implemented at a later date. label Aug 26, 2024
@thrasher-corp thrasher-corp deleted a comment Aug 26, 2024
@thrasher-corp thrasher-corp deleted a comment Aug 26, 2024
@thrasher- thrasher- changed the title Date race in GateIO Data race in GateIO Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority This enhancement or update will be implemented at a later date.
Projects
Status: To Do
Development

No branches or pull requests

1 participant