Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose more thunderstore.toml fields to the CLI #56

Open
4 tasks
abarichello opened this issue Mar 9, 2022 · 2 comments
Open
4 tasks

Expose more thunderstore.toml fields to the CLI #56

abarichello opened this issue Mar 9, 2022 · 2 comments

Comments

@abarichello
Copy link

There's some TOML fields that aren't being exposed by the CLI, this makes using tcli on CI a little more difficult since you have to use sed to change these values after the file is generated.

  • Package description
  • Communities
  • website url
  • dependencies
@Windows10CE
Copy link
Member

These have mostly been looked over since I saw them as "set them and forget them", and didn't really expect them to change between releases without manual editing. I'm fine with adding them, although I do need to be careful of not letting command line args get too long.

Some platforms (cough Windows cmd.exe) put a hard limit on how many bytes can actually be passed as arguments, and I'd rather not encourage the passing of all metadata through args if possible

@MythicManiac
Copy link
Member

As discussed on Discord, it's the intention to expose as much of the config as CLI (and env) parameters as possible. It hasn't been done yet since there isn't a future proof naming scheme for the args drafted yet, and we wanted to avoid breaking them (and thus existing workflows) when one is introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants