Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grab manifest verison with Regex from a file #60

Open
Windows10CE opened this issue Mar 18, 2022 · 3 comments
Open

Grab manifest verison with Regex from a file #60

Windows10CE opened this issue Mar 18, 2022 · 3 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@Windows10CE
Copy link
Member

Allowing the user to do something like

versionNumber = { file = "SourceFile.cs", regex = "const string VERSION = \\\"(.+)\\\";" }

So that a version number would only need to be updated in one place

Is this something I should add? The exact way this would look can change, but would this sort of option be wanted?

@Windows10CE Windows10CE added enhancement New feature or request question Further information is requested labels Mar 18, 2022
@MythicManiac
Copy link
Member

I'd say this falls into the same category as #59, so eventually supporting version extraction like this could be nice, but there's no reason we need first hand support for it at this stage given that there's a myriad of other tools that can be used to automate it already.

Given that there are good alternatives available, it's easier to leave it out of our scope than come up with a future-proof way of handling this (and potential similar future needs).

@PhantomGamers
Copy link

Yes, this would be great.

The BepInEx templates currently use a tag within the csproj so I've been parsing that as xml in my build workflows (e.g. https://github.com/PhantomGamers/DSPAchievementsEnabler/blob/main/.github/workflows/workflow.yml#L15-L24), but allowing for a regex input would be better to cover more cases.

@MythicManiac
Copy link
Member

MythicManiac commented Mar 18, 2022

👆 is a perfect example on why at this point I'd consider first hand support for it scope creep (for the MVP, long term it should be done), as it's not particularly solving anything that can't already be done.

Before all the core features are in place, it would be good to document the alternatives we're aware of however

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants