Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'pjax:end' event #43

Open
staabm opened this issue Mar 23, 2018 · 3 comments
Open

'pjax:end' event #43

staabm opened this issue Mar 23, 2018 · 3 comments

Comments

@staabm
Copy link

staabm commented Mar 23, 2018

does this lib intentionally not support the pjax:end which the origin lib does?

@thybag
Copy link
Owner

thybag commented Mar 23, 2018

Ahoy,

Not intentionally at least - I've not had a chance to really look at this lib in quite some time, so its now potentially a few years behind jquery-pjax, and may well be missed some of the newer features.

Although it tries to do same job, it is also a totally different codebase/implementation so does do some things very differently to jquery-pjax.

In this case i suspect the complete event will probably do what you want, as it fires after the HTML on the current page has been updated etc

@staabm
Copy link
Author

staabm commented Mar 23, 2018

thx for your answer.

the original lib supports complete and end, see https://github.com/defunkt/jquery-pjax#events

would you support changes to this lib which renders it more in-line with the upstream?
or wouldn't you accept those changes because of BC concerns?

@thybag
Copy link
Owner

thybag commented Apr 4, 2018

If your happy to do a PR, i have no objection to there being an end event etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants