Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config(prow/config): migrate review plugins to lgtm + approve for repos in pingcap ORG #868

Merged
merged 6 commits into from
Jun 2, 2023

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented May 23, 2023

Signed-off-by: wuhuizuo [email protected]

What problem does this PR solve?

Issue Number: close #824

Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 23, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2023
@ti-chi-bot ti-chi-bot bot requested a review from purelind May 23, 2023 07:26
@ti-chi-bot ti-chi-bot bot added approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 23, 2023
- pingcap/br
- pingcap/dm
- pingcap/parser
- pingcap/dumping

Signed-off-by: wuhuizuo <[email protected]>
@wuhuizuo wuhuizuo marked this pull request as ready for review May 23, 2023 08:32
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2023
@wuhuizuo
Copy link
Contributor Author

/hold
wait for v7.1 be released.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2023
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Jun 2, 2023

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2023
@ghost
Copy link

ghost commented Jun 2, 2023

/lgtm

@ti-chi-bot ti-chi-bot bot assigned ghost Jun 2, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 2, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo, zuo-bot-1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 2, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-02 10:45:22.300508193 +0000 UTC m=+1734162.982125134: ☑️ agreed by zuo-bot-1.

@ti-chi-bot ti-chi-bot bot merged commit 68d35e5 into main Jun 2, 2023
@ti-chi-bot ti-chi-bot bot deleted the feature/migrate-lgtm-for-repos branch June 2, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REQUEST: add prow OWNERS file to these repos and make prow config changes
1 participant