-
Notifications
You must be signed in to change notification settings - Fork 1
feat: support consider lgtm-like comment as review #44
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
Codecov Report
@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 88.62% 88.74% +0.11%
==========================================
Files 14 14
Lines 378 382 +4
Branches 55 57 +2
==========================================
+ Hits 335 339 +4
Misses 29 29
Partials 14 14
Continue to review full report at Codecov.
|
@Mini256 Why we need this? |
Because the user may only enter the comment of |
/hold |
Actually, I don't know what the point of this record is?It's pretty much useless as it stands and would break the ability to persist GitHub reviews. |
The last review time will not affect the persist of GitHub reviews. |
Got it. But there still seems to be an invalid /lgtm problem? |
Indeed. |
@Mini256: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
CheckedList
Related
close #38