Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm publish from build/ #50

Open
tiagob opened this issue May 27, 2020 · 2 comments
Open

npm publish from build/ #50

tiagob opened this issue May 27, 2020 · 2 comments

Comments

@tiagob
Copy link
Owner

tiagob commented May 27, 2020

Right now it's including everything in npm pack under packages/create-full-stack. It only needs to include what tsc compiles into build/ and any templates.

It needs to copy over the templates directory or make templates packages (#49)

Using files in npm package.json like CRA does is confusing because it's in packages/create-full-stack and packages/create-full-stack/build so the filter gets applied twice (ex. if templates is in files it doesn't get included in npm pack)
https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/package.json#L22-L23 (this isn't needed because they moved them to packages)

Is there a way to always publish from build/? Could lerna handle this? Trying to overwrite the publish script in package.json with yarn --cwd build/ publish doesn't work

@tiagob
Copy link
Owner Author

tiagob commented May 30, 2020

@tiagob tiagob closed this as completed in 7f7d535 May 30, 2020
@tiagob
Copy link
Owner Author

tiagob commented May 30, 2020

Didn't work. --contents requires that all packages use a dist/build model but only create-full-stack has this. Could copy all the contents into a build folder in the other packages in a "prepare" script

@tiagob tiagob reopened this May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant