Skip to content
This repository has been archived by the owner on Oct 12, 2024. It is now read-only.

__init__.py detection does not assume the existence of from specification of packages #19

Closed
TatsuyaShirakawa opened this issue Nov 10, 2021 · 4 comments

Comments

@TatsuyaShirakawa
Copy link

If the project is organized like

root
   |- src
   |     |- my_package
   |- pyproject.toml

and pyproject.toml is like

[tool.poetry]
...
packages = [
    { include = "my_package" from = "src" }
]
...
[tool.poetry-version-plugin]
source = "init"

then, the detection of __init__.py fails.

It is because, I think, the __init__.py detection logic here does not consider the from value.

@jessekrubin
Copy link

Same for me.

@dekoza
Copy link

dekoza commented Feb 2, 2022

Fixed with #20 🙂

@setu4993
Copy link

@tiangolo : If possible for you, would be great to incorporate PR #20. I'd love to use this plugin but because I use the src structure, the current release version doesn't work for me :/.

@tiangolo
Copy link
Owner

tiangolo commented Sep 8, 2024

Thanks for the patience with my reply! 😅

I just marked this project as deprecated, I'm currently not using it and I think these ideas can be achieved in better ways: https://github.com/tiangolo/poetry-version-plugin#-warning-deprecated-

Given that I'll close this one, but thanks for the interest! ☕

@tiangolo tiangolo closed this as completed Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants