Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PatchCheck.py does not detect you did not configure "BaseTools/Scripts/SetupGit.py (Bugzilla Bug 2767) #71

Open
tianocore-issues opened this issue May 26, 2020 · 2 comments

Comments

@tianocore-issues
Copy link

This issue was created automatically with bugzilla2github

Bugzilla Bug 2767

Date: 2020-05-26T00:07:45+00:00
From: @ajfish
To: @mdkinney
CC: nobody

Last updated: 2020-05-26T21:45:53+00:00

@tianocore-issues
Copy link
Author

Comment 12705

Date: 2020-05-26 00:07:45 +0000
From: @ajfish

  • Industry Specification: ---
  • Target OS: ---
  • Bugzilla Assignee(s): @mdkinney

I was configuring a system to do edk2 contribution and I did not run BaseTools/Scripts/SetupGit.py and my patch got rejected, but PatchCheck.py passed.

This seems like a bad bug in PatchCheck.py

@tianocore-issues
Copy link
Author

Comment 12713

Date: 2020-05-26 21:45:53 +0000
From: nobody <>

What means the patch got rejected?

What change is required in PatchCheck.py to fix this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant