Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 22 support #87

Closed
m1ga opened this issue Jun 17, 2024 · 7 comments
Closed

Node 22 support #87

m1ga opened this issue Jun 17, 2024 · 7 comments
Assignees

Comments

@m1ga
Copy link
Contributor

m1ga commented Jun 17, 2024

would it be possible to update #84 for Node 22?

@cb1kenobi
Copy link
Contributor

node-ios-device 3 should already support Node 22. We should update ioslib to use it.

@cb1kenobi cb1kenobi self-assigned this Jun 17, 2024
@m1ga
Copy link
Contributor Author

m1ga commented Jun 17, 2024

there is no node_ios_device-v1.11.0-node-v127-darwin-arm64.tar.gz. There was one slack report where it tried to download the v127 with node 22.3.0 and that file is not in the https://github.com/tidev/node-ios-device/releases/tag/v1.11.0 assets list

@cb1kenobi
Copy link
Contributor

Right. We could see about adding support for Node 22, or we could update ioslib to node-ios-device@3. I don't know the level of effort, but it's probably not bad.

FYI, I plan to migrate node-ios-device@3 to ESM and release it as v4, so we should clean up v3, then use that. Besides, v3 has some nice features aside from being futureproofed.

@m1ga
Copy link
Contributor Author

m1ga commented Jun 17, 2024

ah, now I get it 😄 I forgot that there is a v1 / v3 here. The PR above looked like a quick way to add support in a short term but since we are going to update ioslib for the new Xcode version we could go to v3/v4 too 👍

@cb1kenobi
Copy link
Contributor

Bingo. So I can clean up v3 (deps, verify Node 22, etc), but no ESM. Then we can update ioslib to use v3. After all that, then I'll move node-ios-device to ESM and call it v4.

@ewanharris
Copy link
Contributor

ewanharris commented Jun 18, 2024

Adding Node 22 support to the existing 1.X version was simple enough to fit into my lunch break so made #88 🙂

If I remember right, node-ios-device v3 didn't have feature parity?

@cb1kenobi
Copy link
Contributor

[email protected] published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants