Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frameHeight, frameWidth not working in latest Android release #93

Open
cboz718 opened this issue Oct 26, 2018 · 6 comments
Open

frameHeight, frameWidth not working in latest Android release #93

cboz718 opened this issue Oct 26, 2018 · 6 comments

Comments

@cboz718
Copy link

cboz718 commented Oct 26, 2018

I've been trying to get frameWidth and frameHeight working on Android in my project as I need the rectangle a bit shorter to make some room for overlay elements, but it doesn't seem to make any difference. I tried running my code on version 3.1.0 where the feature was released, and it resized the rectangle fine. Currently running 7.4.1 SDK with Android module version 4.0.1. Is this still supported?

	Barcode.capture({
		animate : true,
		overlay : overlay,
		showCancel : false,
		showRectangle : true,
		keepOpen : true,
		frameWidth : 250,
		frameHeight : 250
	});
@m1ga
Copy link
Contributor

m1ga commented Oct 26, 2018

looks like it was removed in this PR #61
I'll add it again!

@cboz718
Copy link
Author

cboz718 commented Oct 26, 2018

Awesome, thanks for the quick response!

@cjadhav
Copy link

cjadhav commented Nov 29, 2018

Hi @m1ga,

By when we should expect next release with this fix.??

Thanks!

@m1ga
Copy link
Contributor

m1ga commented Nov 29, 2018

I've added a binary: https://github.com/appcelerator-modules/ti.barcode/releases/download/untagged-23543217cdfc0d5ca9b2/ti.barcode-android-4.0.2.zip
The fix is included in #89 so once that is merged it will be fine again

@cjadhav
Copy link

cjadhav commented Nov 30, 2018

Thank you so much @m1ga.
But It seems the link is not open for all. It shows Not Found error.
Can you please share zip in comment ..?? or any other link to download.??

@m1ga
Copy link
Contributor

m1ga commented Nov 30, 2018

here is another download link: http://migaweb.de/ti.barcode-android-4.0.2.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants