Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Channel not up to date docs #14106

Closed
1 task done
Informate opened this issue Sep 5, 2024 · 4 comments · Fixed by #14107
Closed
1 task done

Notification Channel not up to date docs #14106

Informate opened this issue Sep 5, 2024 · 4 comments · Fixed by #14107
Labels
bug docs needs triage This issue hasn't been reviewed by maintainers

Comments

@Informate
Copy link

Informate commented Sep 5, 2024

I have searched and made sure there are no existing issues for the issue I am filing

  • I have searched the existing issues

URL

https://titaniumsdk.com/api/titanium/android/notificationchannel.html

Description

In the example a non existent method getId is used, while the doc for the audioStreamType attribute seems merged into the importance attribute docs. The audioStreamType results undocumented and the correct availables values are unknown.

Suggestion

X

@Informate Informate added bug docs needs triage This issue hasn't been reviewed by maintainers labels Sep 5, 2024
@m1ga
Copy link
Contributor

m1ga commented Sep 5, 2024

getId() is just .id now: https://titaniumsdk.com/api/titanium/android/notificationchannel.html#properties_id
it's the old getter/setter update in Ti 10.

audiostreamtype is here: https://titaniumsdk.com/api/titanium/android/notification.html#audiostreamtype

You can also fork the repo and make the changes. Pull requests are always welcome!

@m1ga
Copy link
Contributor

m1ga commented Sep 5, 2024

fix: #14107

@Informate
Copy link
Author

Super fast fixing :)))

@m1ga
Copy link
Contributor

m1ga commented Sep 5, 2024

No problem 😄 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug docs needs triage This issue hasn't been reviewed by maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants