Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rowwise not applicable #236

Open
verajosemanuel opened this issue Apr 12, 2021 · 7 comments
Open

rowwise not applicable #236

verajosemanuel opened this issue Apr 12, 2021 · 7 comments
Labels
feature a feature request or enhancement

Comments

@verajosemanuel
Copy link

verajosemanuel commented Apr 12, 2021

As documentation states, dtplyr seems to include all dplyr 1.0 verbs. But got an error when trying to use rowwise (maybe I am wrong and this verb is not included)

https://www.tidyverse.org/blog/2020/04/dplyr-1-0-0-rowwise/

 mtcars2 <- lazy_dt(mtcars)

mtcars2 %>% rowwise()

Error in UseMethod("rowwise") : 
  no applicable method for 'rowwise' applied to an object of class "c('dtplyr_step_first', 'dtplyr_step')"
@markfairbanks
Copy link
Collaborator

Sorry for the late response on this one. rowwise() is not currently implemented in dtplyr. We should be able to implement this when the newest version of data.table is on CRAN.

This new feature is the one we're waiting on.

@markfairbanks markfairbanks added the feature a feature request or enhancement label Jun 21, 2022
@kurttaylor
Copy link

Any update on this @markfairbanks ?

@markfairbanks
Copy link
Collaborator

@kurttaylor we’re still waiting on the next CRAN release of data.table for the feature to be available. Until then we won’t be able to add it to dtplyr unfortunately.

data.table‘s last CRAN release was Feb 2021. I’m not sure why it has been so long since their last release, so it’s tough to guess when their next one might be. Hopefully in the next few months.

@bachlaw
Copy link

bachlaw commented Feb 3, 2023

Looks like data.table might have finally pushed the necessary release to CRAN?

@markfairbanks
Copy link
Collaborator

markfairbanks commented Feb 3, 2023

They've had a few mini-releases since v1.14.0 in Feb 2021 (v1.14.2, v1.14.4, and v1.14.6), however these were all fixes intended to pass new CRAN requirements. All new features since v1.14.0 are still in the development version.

The addition we're waiting on is number 39 in the development version news:

39. .I is now available in by for rowwise operations, https://github.com/Rdatatable/data.table/issues/1732.
Thanks to Rafael H. M. Pereira for requesting, and Benjamin Schwendinger for the PR.

@DanSimonet
Copy link

DanSimonet commented Mar 14, 2024

It appears with the recent v1.15.0 data.table release in January the .I function is now available for rowwise operations per their news and reference manual update. Do you anticipate the updated being integrated into the next dtplyr release?

@markfairbanks
Copy link
Collaborator

Do you anticipate the updated being integrated into the next dtplyr release?

Yep, I think that's a very realistic goal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

5 participants