Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better names for duckplyr_df_from_csv() and duckplyr_df_from_parquet() #210

Open
hadley opened this issue Jul 25, 2024 · 7 comments
Open
Milestone

Comments

@hadley
Copy link
Member

hadley commented Jul 25, 2024

I was thinking that read_csv_lazy() and read_parquet_lazy() might more clearly convey their usage.

@hadley
Copy link
Member Author

hadley commented Sep 4, 2024

Or maybe read_csv_duckplyr() or similar.

I find the current selection of function names to be quite confusing.

@hadley hadley added this to the 1.0.0 milestone Sep 25, 2024
@DavisVaughan
Copy link
Member

My vote is for read_csv_duckplyr(), just "lazy" as the suffix doesn't feel quite right (too ambiguous?)

But keeping the read_csv_ as the prefix is quite nice for muscle memory with readr and autocomplete

@hannes
Copy link
Contributor

hannes commented Sep 25, 2024

we should also have some functions of output, e.g. write_parquet_duckplyr() or something like that

@krlmlr

This comment was marked as duplicate.

@hannes
Copy link
Contributor

hannes commented Oct 16, 2024

happy with read_*_duckplyr

@krlmlr
Copy link
Member

krlmlr commented Oct 17, 2024

DoD:

  • Review duckdbfs API (very similar scope as these functions)
  • Find names and agree
  • Add deprecation warnings
  • Implement with new names
  • Add an argument to disable automatic materialization
  • Release to CRAN

@krlmlr
Copy link
Member

krlmlr commented Nov 10, 2024

Let's go with the full lifecycle changes. We now also have the infrastructure to disable automatic materialization, this seems most useful when reading directly from a file, and will provide an incentive to use the new functions. This needs #255.

I wonder if the new functions should turn auto-mat on or off by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants