You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
abort("dplyr must be installed to work with tbl objects")
}
dplyr::collect(model)
}
Suggestions
I suggest
Deprecate fortify.lm(), fortify.glht(), fortify.confint.glht(), fortify.summary.glht() and fortify.cld(). Replace examples using broom::augment() and broom::tidy().
Deprecate fortify.<sp-object> and fortify.map() after ensuring geom_sf() supersedes geom_map().
Merge the docs of fortify() to autoplot() and autolayer(), and explain how developers of some custom objects can implements these methods so that the users can use ggplot2 to visualize the objects painlessly (Mark geom_map() as superseded #3721).
Note that this issue is not very high priority as maintaining fortify() doesn't seem a heavy burden, at least at the moment. I filed this issue just because it seems we need some place to discuss to avoid confusion. Anyway, I believe it's a right move to encourage users to use broom and sf.
The text was updated successfully, but these errors were encountered:
(Originally commented at #3802 (comment))
In my understanding, there are 2 purposes of
fortify()
.For purpose 1, ggplot2 now provides 2 types of methods, both of which are becoming less important:
geom_sf()
.So, we can and should deprecate (or at least discourage) this type of usages.
On the other hand, for purpose 2, I think
fortify()
still plays a somehow important role. For example,fortify.tbl()
ensurestbl
iscollect()
ed.ggplot2/R/fortify.r
Lines 19 to 24 in 0137a4d
Suggestions
I suggest
fortify.lm()
,fortify.glht()
,fortify.confint.glht()
,fortify.summary.glht()
andfortify.cld()
. Replace examples usingbroom::augment()
andbroom::tidy()
.fortify.<sp-object>
andfortify.map()
after ensuringgeom_sf()
supersedesgeom_map()
.fortify()
toautoplot()
andautolayer()
, and explain how developers of some custom objects can implements these methods so that the users can use ggplot2 to visualize the objects painlessly (Mark geom_map() as superseded #3721).Note that this issue is not very high priority as maintaining
fortify()
doesn't seem a heavy burden, at least at the moment. I filed this issue just because it seems we need some place to discuss to avoid confusion. Anyway, I believe it's a right move to encourage users to use broom and sf.The text was updated successfully, but these errors were encountered: