Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the current status of fortify() #3816

Open
1 of 3 tasks
yutannihilation opened this issue Feb 11, 2020 · 2 comments
Open
1 of 3 tasks

Clarify the current status of fortify() #3816

yutannihilation opened this issue Feb 11, 2020 · 2 comments
Labels
breaking change ☠️ API change likely to affect existing code layers 📈

Comments

@yutannihilation
Copy link
Member

yutannihilation commented Feb 11, 2020

(Originally commented at #3802 (comment))

In my understanding, there are 2 purposes of fortify().

  1. User-facing utility to convert an object to data.frame, which otherwise the users don't know how to.
  2. API for developers that let the custom objects handled nicely in the internal of ggplot2 by tweaking the object at the very first stage.

For purpose 1, ggplot2 now provides 2 types of methods, both of which are becoming less important:

  • Convert model objects, which is superseded broom package. In addition, ggfortify covers much wider range of objects.
  • Convert geospatial objects (of sp and maps), which is being superseded by sf package and geom_sf().

So, we can and should deprecate (or at least discourage) this type of usages.

On the other hand, for purpose 2, I think fortify() still plays a somehow important role. For example, fortify.tbl() ensures tbl is collect()ed.

ggplot2/R/fortify.r

Lines 19 to 24 in 0137a4d

fortify.tbl <- function(model, data, ...) {
if (!requireNamespace("dplyr", quietly = TRUE)) {
abort("dplyr must be installed to work with tbl objects")
}
dplyr::collect(model)
}

Suggestions

I suggest

  • Deprecate fortify.lm(), fortify.glht(), fortify.confint.glht(), fortify.summary.glht() and fortify.cld(). Replace examples using broom::augment() and broom::tidy().
  • Deprecate fortify.<sp-object> and fortify.map() after ensuring geom_sf() supersedes geom_map().
  • Merge the docs of fortify() to autoplot() and autolayer(), and explain how developers of some custom objects can implements these methods so that the users can use ggplot2 to visualize the objects painlessly (Mark geom_map() as superseded #3721).

Note that this issue is not very high priority as maintaining fortify() doesn't seem a heavy burden, at least at the moment. I filed this issue just because it seems we need some place to discuss to avoid confusion. Anyway, I believe it's a right move to encourage users to use broom and sf.

@hadley hadley added layers 📈 breaking change ☠️ API change likely to affect existing code labels Mar 14, 2022
@hadley
Copy link
Member

hadley commented Mar 14, 2022

This sounds like a good proposal to me, but it'll need to wait until a major/minor release.

@teunbrand
Copy link
Collaborator

I'm considering the docs bullet adressed by #5745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ☠️ API change likely to affect existing code layers 📈
Projects
None yet
Development

No branches or pull requests

3 participants