Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cherry-pick and add image_segmentation_based_filter for beta/v0.29.0 #1526

Merged
merged 11 commits into from
Sep 10, 2024

Conversation

badai-nguyen
Copy link

@badai-nguyen badai-nguyen commented Sep 9, 2024

Description

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

badai-nguyen and others added 8 commits September 2, 2024 20:41
…el with semantic segmentation header (autowarefoundation#5553)

* add segmentation model

Signed-off-by: badai-nguyen <[email protected]>

fix: add multitask for segment

Signed-off-by: badai-nguyen <[email protected]>

* fix: publish mask

Signed-off-by: badai-nguyen <[email protected]>

* feat: publish colorized mask

Signed-off-by: badai-nguyen <[email protected]>

* fix: resize yolox mask

Signed-off-by: badai-nguyen <[email protected]>

* fix: add memory allocate operations

Signed-off-by: Manato HIRABAYASHI <[email protected]>

* refactor: remove underscore for a local variable

Signed-off-by: Manato HIRABAYASHI <[email protected]>

* chore: add condition to check the number of subscriber for newly added topics

Signed-off-by: Manato HIRABAYASHI <[email protected]>

* chore: pre-commit

Signed-off-by: badai-nguyen <[email protected]>

* fix: add roi overlapping segment

Signed-off-by: badai-nguyen <[email protected]>

* fix: roi overlay segment

Signed-off-by: badai-nguyen <[email protected]>

* chore: refactor

Signed-off-by: badai-nguyen <[email protected]>

* docs: update readme

Signed-off-by: badai-nguyen <[email protected]>

* fix: update model name

Signed-off-by: badai-nguyen <[email protected]>

* fix: add utils into tensorrt_yolox

Signed-off-by: badai-nguyen <[email protected]>

* fix: launch file

Signed-off-by: badai-nguyen <[email protected]>

* chore: remove unnecessary depend

Signed-off-by: badai-nguyen <[email protected]>

* chore: fix yaml file

Signed-off-by: badai-nguyen <[email protected]>

* chore: remove duplicated param in launch

Signed-off-by: badai-nguyen <[email protected]>

* fix: semantic class

Signed-off-by: badai-nguyen <[email protected]>

* docs: update readme

Signed-off-by: badai-nguyen <[email protected]>

* chore: update default param

Signed-off-by: badai-nguyen <[email protected]>

* fix: add processing time topic

Signed-off-by: badai-nguyen <[email protected]>

* chore: typo

Signed-off-by: badai-nguyen <[email protected]>

* style(pre-commit): autofix

* chore: fix cspell error

Signed-off-by: badai-nguyen <[email protected]>

* fix: yolox default param

Signed-off-by: badai-nguyen <[email protected]>

* chore: rename debug topics

Signed-off-by: badai-nguyen <[email protected]>

* chore: rename debug topics

Signed-off-by: badai-nguyen <[email protected]>

* docs: update model description

Signed-off-by: badai-nguyen <[email protected]>

* style(pre-commit): autofix

* fix: launch

Signed-off-by: badai-nguyen <[email protected]>

* refactor: unpublish mask for single task

Signed-off-by: badai-nguyen <[email protected]>

* Update perception/tensorrt_yolox/src/tensorrt_yolox.cpp

Co-authored-by: Manato Hirabayashi <[email protected]>

* Update perception/tensorrt_yolox/src/tensorrt_yolox.cpp

Co-authored-by: Manato Hirabayashi <[email protected]>

* Update perception/tensorrt_yolox/src/tensorrt_yolox.cpp

Co-authored-by: Manato Hirabayashi <[email protected]>

* style(pre-commit): autofix

* docs: update reamde

Signed-off-by: badai-nguyen <[email protected]>

* style(pre-commit): autofix

* fix: skip mask size as yolox output

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: Manato HIRABAYASHI <[email protected]>
Co-authored-by: Manato HIRABAYASHI <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Manato Hirabayashi <[email protected]>
… mask (autowarefoundation#7905)

* fix: add rle compress

Signed-off-by: badai-nguyen <[email protected]>

* fix: rle compress

Signed-off-by: badai-nguyen <[email protected]>

* fix: move rle into utils

Signed-off-by: badai-nguyen <[email protected]>

* chore: pre-commit

Signed-off-by: badai-nguyen <[email protected]>

* Update perception/autoware_tensorrt_yolox/src/utils.cpp

Co-authored-by: Yukihiro Saito <[email protected]>

* fix: remove unused variable

Signed-off-by: badai-nguyen <[email protected]>

* Update perception/autoware_tensorrt_yolox/src/utils.cpp

Co-authored-by: Manato Hirabayashi <[email protected]>

* style(pre-commit): autofix

* feat: add unit test for utils

Signed-off-by: badai-nguyen <[email protected]>

* style(pre-commit): autofix

* fix: unit test

Signed-off-by: badai-nguyen <[email protected]>

* chore: change to explicit index

Signed-off-by: badai-nguyen <[email protected]>

* style(pre-commit): autofix

* fix: cuda cmake

Signed-off-by: badai-nguyen <[email protected]>

* fix: separate unit test into different PR

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
Co-authored-by: Yukihiro Saito <[email protected]>
Co-authored-by: Manato Hirabayashi <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…oundation#8435)

* chore(tensorrt_yolo): refactor utils

Signed-off-by: badai-nguyen <[email protected]>

* style(pre-commit): autofix

* fix: tensorrt_yolox

Signed-off-by: badai-nguyen <[email protected]>

---------

Signed-off-by: badai-nguyen <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ntation_pointcloud_fusion (autowarefoundation#7909)

* fix: add rle decompress

Signed-off-by: badai-nguyen <[email protected]>

* style(pre-commit): autofix

* fix: use rld in tensorrt utils

Signed-off-by: badai-nguyen <[email protected]>

* fix: rebase error

Signed-off-by: badai-nguyen <[email protected]>

* fix: dependency

Signed-off-by: badai-nguyen <[email protected]>

* fix: skip publish debug mask

Signed-off-by: badai-nguyen <[email protected]>

* Update perception/autoware_image_projection_based_fusion/src/segmentation_pointcloud_fusion/node.cpp

Co-authored-by: kminoda <[email protected]>

* style(pre-commit): autofix

* Revert "fix: skip publish debug mask"

This reverts commit 30fa9ae.

---------

Signed-off-by: badai-nguyen <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: kminoda <[email protected]>
…d filter (autowarefoundation#7225)

* feat(tier4_perception_launch): add image segmentation based pointcloud filter

Signed-off-by: badai-nguyen <[email protected]>

* chore: typo

Signed-off-by: badai-nguyen <[email protected]>

* fix: detection launch

Signed-off-by: badai-nguyen <[email protected]>

* chore: add maintainer

Signed-off-by: badai-nguyen <[email protected]>

* Revert "chore: add maintainer"

This reverts commit 5adfef6.

---------

Signed-off-by: badai-nguyen <[email protected]>
Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shmpwk
Copy link
Collaborator

shmpwk commented Sep 9, 2024

@badai-nguyen
PRありがとうございます!
jetson_launcherの変更やmlmodelをwebauto-ci.ymlで入れるPRがreadyになってからマージしたいです。

…ntation pointcloud fusion node failing with multiple mask inputs (autowarefoundation#8769)
@badai-nguyen
Copy link
Author

badai-nguyen commented Sep 10, 2024

@shmpwk
autoware_launchのデフォルト:=falseを追加するPR(tier4/autoware_launch#586 ) も作成しました。
一旦この2つのPRを入れて置き、Roscube の変更済み車両に対して use_image_segmentation_based_filter:=true に変更していくという形でよろしいですしょうか

@shmpwk
Copy link
Collaborator

shmpwk commented Sep 10, 2024

@badai-nguyen
ありがとうございます、はい賛成です!

@badai-nguyen badai-nguyen merged commit 2077fae into beta/v0.29.0 Sep 10, 2024
20 of 21 checks passed
@badai-nguyen badai-nguyen deleted the exp/beta/v0.29.0-semseg-filter branch September 10, 2024 06:01
Copy link

sonarcloud bot commented Sep 10, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants