Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stop_filter): extract stop_filter.param.yaml to autoware_launch (#8681) #1591

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented Oct 17, 2024

Description

autowarefoundation#8681 のbackport

Related links

Parent Issue:

How was this PR tested?

下記PRと一緒に確認する

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…autowarefoundation#8681)

Extract stop_filter.param.yaml to autoware_launch

Signed-off-by: TaikiYamada4 <[email protected]>
Copy link

sonarcloud bot commented Oct 17, 2024

Copy link

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動作確認とかは全くしていませんが、見た目として間違ってはいなさそうな雰囲気なのでapproveは出します

@h-ohta
Copy link
Author

h-ohta commented Oct 17, 2024

@SakodaShintaro ありがとうございます。動作確認についてはX2チーム内で実施しますので、大丈夫です

@h-ohta h-ohta marked this pull request as ready for review October 23, 2024 01:25
@h-ohta h-ohta merged commit bad0007 into beta/v0.29.0-1 Oct 23, 2024
24 of 26 checks passed
@h-ohta h-ohta deleted the backport/8681 branch October 23, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants