Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add Ring-Based Filter for Removing Reflected and Vehicle Points #60

Open
mebasoglu opened this issue Aug 29, 2023 · 2 comments · May be fixed by #69
Open

Enhancement: Add Ring-Based Filter for Removing Reflected and Vehicle Points #60

mebasoglu opened this issue Aug 29, 2023 · 2 comments · May be fixed by #69

Comments

@mebasoglu
Copy link
Collaborator

Overview

The proposed enhancement introduces a ring-based filtering mechanism to the existing functionality of the repository. This feature aims to remove unwanted points from specified rings within defined angle ranges, specifically targeting reflected and vehicle points directly within the driver. The intention is to elude crop box filters to decrease the delay of the sensing pipeline.

Details

The key aspects of this feature include:

  1. Point Removal: The feature allows for the removal of points based on their position within specified rings.

  2. Ring and Angle Specification: Users will be able to define which rings they want to apply filtering to. Each ring will be associated with one or more angle ranges for removal.

  3. Angle Ranges: For each specified ring, users can define multiple angle ranges within which points should be removed. These angle ranges are determined by the starting and ending angles.

  4. Fine-Tuned Filtering: The ability to define multiple angle ranges for a single ring provides fine-tuned control over the filtering process, enabling users to selectively remove points.

Usage Example:

<arg name="invalid_point_remove" default="true"/> <arg name="invalid_rings" default="[3, 5, 7, 7]"/> <arg name="invalid_angles_start" default="[120, 250, 180, 230]"/> <arg name="invalid_angles_end" default="[200, 300, 220, 245]"/>

Expected Behavior: Upon enabling the invalid_point_remove option and specifying the relevant invalid_rings, invalid_angles_start, and invalid_angles_end configurations, the ring-based filter will remove points located within the defined angle ranges for the specified rings.

Could you please provide any feedback, suggestions, and guidance on the proposed enhancement @drwnz @amc-nu ?

@drwnz
Copy link
Collaborator

drwnz commented Aug 29, 2023

@mebasoglu thank you for the proposal.
I imagine this works at the decoder level, requiring an implementation for each sensor? This would be the fastest implementation, but require more work in implementation than adding a separate node which filters from the output pointcloud and publishes a new topic.

@mebasoglu
Copy link
Collaborator Author

mebasoglu commented Aug 29, 2023

Yes, I thought a decoder level implementation for each sensor, so that we can deactivate crop box filters to remove vehicle points.
It could be also useful to remove reflected points from the vehicle's glasses:

arrowed

@mebasoglu mebasoglu linked a pull request Sep 6, 2023 that will close this issue
5 tasks
@mebasoglu mebasoglu linked a pull request Mar 8, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants