Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fork backtrace-rs #185

Closed
wants to merge 1 commit into from
Closed

Fork backtrace-rs #185

wants to merge 1 commit into from

Conversation

hehechen
Copy link

@hehechen hehechen commented Dec 8, 2022

Signed-off-by: hehechen [email protected]
Closes: #184
Fork backtrace-rs and modify MAPPINGS_CACHE_SIZE to 10.

YangKeao
YangKeao reviewed Dec 8, 2022
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@hehechen
fork backtrace-rs
c43d3b2 
Signed-off-by: hehechen <[email protected]>
YangKeao
YangKeao approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao
Copy link
Member

Wait a minute. #188 will fix the CI.

@sticnarf
Copy link
Contributor

I'm worrying whether there will be problems if the user links different backtrace-rs libraries.
@hehechen Is it acceptable for you to patch at your binary? And we update backtrace-rs until unstream accepts your patch.

@hehechen
Copy link
Author

hehechen commented Jan 9, 2023

I will patch to TiKV and TiFlash proxy. tikv/tikv#14026

@hehechen hehechen closed this Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangKeao YangKeao YangKeao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fork backtrace-rs and modify MAPPINGS_CACHE_SIZE to 10
3 participants
@hehechen @YangKeao @sticnarf