Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test all flags #11

Open
20 of 28 tasks
timcallow opened this issue Dec 18, 2024 · 1 comment
Open
20 of 28 tasks

Test all flags #11

timcallow opened this issue Dec 18, 2024 · 1 comment

Comments

@timcallow
Copy link
Owner

timcallow commented Dec 18, 2024

So far, testing has been mostly restricted to the --output flag for the new functions schedule, finish, and reschedule.

We need to make sure all the command line flags are thoroughly tested. The list is below. N.B., some of these command line options may not need to be present. They are inherited from datalad run and datalad rerun and might not be necessary for the slurm commands.

datalad schedule

  • dataset
  • inputs
  • outputs
  • expand
  • assume_ready
  • message
  • check_outputs
  • sidecar
  • dry_run
  • jobs

datalad finish

  • commit
  • since
  • branch
  • onto
  • dataset
  • outputs
  • close-failed-jobs
  • list-open-jobs
  • jobs

datalad reschedule

  • revision
  • since
  • branch
  • onto
  • script
  • dataset
  • report
  • assume_ready
  • jobs
@timcallow
Copy link
Owner Author

timcallow commented Jan 2, 2025

We will delete the following flags in the interest of simplicity. They can be reintroduced later if there's a particular desire:

datalad schedule

  • assume-ready (it is very abnormal to not have outputs required in datalad-schedule)
  • sidecar

datalad finish

  • branch (this option was inherited from datalad rerun and doesn't make sense for datalad finish)
  • onto (as above)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant