From 1102d34f42daf24a6fdbbbcae2c6e46feb50ca8c Mon Sep 17 00:00:00 2001
From: Mats Kindahl <mats@timescale.com>
Date: Thu, 10 Aug 2023 13:53:57 +0200
Subject: [PATCH] Remove telemetry isolation test

The telemetry isolation test `telemetry_iso` does not test anything and
does not seem to work, so it is removed. The debug waitpoint was taken
in the same session, so the waitpoint was not waited on.
---
 tsl/test/isolation/expected/telemetry_iso.out | 26 --------------
 tsl/test/isolation/specs/CMakeLists.txt       |  3 +-
 tsl/test/isolation/specs/telemetry_iso.spec   | 35 -------------------
 3 files changed, 1 insertion(+), 63 deletions(-)
 delete mode 100644 tsl/test/isolation/expected/telemetry_iso.out
 delete mode 100644 tsl/test/isolation/specs/telemetry_iso.spec

diff --git a/tsl/test/isolation/expected/telemetry_iso.out b/tsl/test/isolation/expected/telemetry_iso.out
deleted file mode 100644
index c485ad22982..00000000000
--- a/tsl/test/isolation/expected/telemetry_iso.out
+++ /dev/null
@@ -1,26 +0,0 @@
-Parsed test spec with 2 sessions
-
-starting permutation: s1_wp_enable s2_telemetry_report s1_drop_chunks s1_decompress s1_insert_new_chunk s1_compress s1_wp_release
-step s1_wp_enable: SELECT debug_waitpoint_enable('telemetry_classify_relation');
-debug_waitpoint_enable
-----------------------
-                      
-(1 row)
-
-step s2_telemetry_report: SELECT t INTO telemetry FROM get_telemetry_report() t; <waiting ...>
-step s1_drop_chunks: SELECT count(*) FROM drop_chunks('compress', timestamptz '2020-01-20 15:00');
-count
------
-    0
-(1 row)
-
-step s1_decompress: SELECT decompress_chunk(c) INTO decompressed_chunks FROM show_chunks('compress') c ORDER BY c LIMIT 10;
-step s1_insert_new_chunk: INSERT INTO compress VALUES ('2020-03-01'::timestamptz, 1, 33.3);
-step s1_compress: SELECT compress_chunk(c) INTO compressed_chunks FROM show_chunks('compress') c ORDER BY c DESC LIMIT 1;
-step s1_wp_release: SELECT debug_waitpoint_release('telemetry_classify_relation');
-debug_waitpoint_release
------------------------
-                       
-(1 row)
-
-step s2_telemetry_report: <... completed>
diff --git a/tsl/test/isolation/specs/CMakeLists.txt b/tsl/test/isolation/specs/CMakeLists.txt
index 746f5a1d720..6f381b3aa7b 100644
--- a/tsl/test/isolation/specs/CMakeLists.txt
+++ b/tsl/test/isolation/specs/CMakeLists.txt
@@ -31,8 +31,7 @@ if(CMAKE_BUILD_TYPE MATCHES Debug)
     dist_ha_chunk_drop.spec
     dist_ha_chunk_drop.spec
     dist_restore_point.spec
-    remote_create_chunk.spec
-    telemetry_iso.spec)
+    remote_create_chunk.spec)
   if(PG_VERSION VERSION_GREATER_EQUAL "14.0")
     list(APPEND TEST_FILES freeze_chunk.spec compression_dml_iso.spec)
   endif()
diff --git a/tsl/test/isolation/specs/telemetry_iso.spec b/tsl/test/isolation/specs/telemetry_iso.spec
deleted file mode 100644
index c61ee7d630d..00000000000
--- a/tsl/test/isolation/specs/telemetry_iso.spec
+++ /dev/null
@@ -1,35 +0,0 @@
-# This file and its contents are licensed under the Timescale License.
-# Please see the included NOTICE for copyright information and
-# LICENSE-TIMESCALE for a copy of the license.
-
-setup {
-  CREATE TABLE compress (time timestamptz, color int, temp float);
-  SELECT create_hypertable('compress', 'time', 'color', 2, chunk_time_interval => interval '1 week');
-  INSERT INTO compress
-  SELECT t, ceil(random() * 10)::int, random() * 30
-  FROM generate_series('2020-01-20'::timestamptz, '2020-02-20', '10m') t;
-  ALTER TABLE compress SET (timescaledb.compress = TRUE);
-  SELECT compress_chunk(c) FROM show_chunks('compress') c ORDER BY c LIMIT 10;
-}
-
-teardown {
-  DROP TABLE compress;
-  DROP TABLE compressed_chunks;
-  DROP TABLE decompressed_chunks;
-  DROP TABLE telemetry;
-}
-
-session "waitpoints"
-step "s1_wp_enable"           { SELECT debug_waitpoint_enable('telemetry_classify_relation'); }
-step "s1_wp_release"      { SELECT debug_waitpoint_release('telemetry_classify_relation'); }
-
-session "s1"
-step "s1_decompress"	{ SELECT decompress_chunk(c) INTO decompressed_chunks FROM show_chunks('compress') c ORDER BY c LIMIT 10; }
-step "s1_insert_new_chunk" { INSERT INTO compress VALUES ('2020-03-01'::timestamptz, 1, 33.3); }
-step "s1_drop_chunks"   { SELECT count(*) FROM drop_chunks('compress', timestamptz '2020-01-20 15:00'); }
-step "s1_compress"      { SELECT compress_chunk(c) INTO compressed_chunks FROM show_chunks('compress') c ORDER BY c DESC LIMIT 1; }
-
-session "s2"
-step "s2_telemetry_report" { SELECT t INTO telemetry FROM get_telemetry_report() t; }
-
-permutation "s1_wp_enable" "s2_telemetry_report" "s1_drop_chunks" "s1_decompress" "s1_insert_new_chunk" "s1_compress" "s1_wp_release"