Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declarative visualizations #10

Open
timothyb0912 opened this issue Nov 13, 2020 · 0 comments
Open

Declarative visualizations #10

timothyb0912 opened this issue Nov 13, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@timothyb0912
Copy link
Owner

timothyb0912 commented Nov 13, 2020

What

This package produces visualizations imperatively. It creates model diagnostic images by directly manipulating matplotlib. Matplotlib makes it very difficult to test the resulting images. I should switch to using declarative visualization methods and packages (e.g. plotnine and altair) because I can easily test the resulting images (altair) and image declarations (plotnine).

At the very least, I can begin by re-implementing the diagnostic plots using a declarative library and exposing those new plotting methods / objects. Then, once I've re-implemented all the plots, I can remove the old plotting methods.

@timothyb0912 timothyb0912 added the bug Something isn't working label Nov 13, 2020
@timothyb0912 timothyb0912 self-assigned this Nov 13, 2020
@timothyb0912 timothyb0912 mentioned this issue Nov 13, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant