Skip to content

Add possibility to disable logging of etna.models.SARIMAXModel #1305

Open
Mr-Geekman opened this issue Jul 4, 2023 · 0 comments
Open

Add possibility to disable logging of etna.models.SARIMAXModel #1305

Mr-Geekman opened this issue Jul 4, 2023 · 0 comments
Labels
enhancement New feature or request priority/medium Medium priority task

Comments

@Mr-Geekman
Copy link
Contributor

Mr-Geekman commented Jul 4, 2023 •
edited
Loading

🚀 Feature Request

Currently model etna.models.SARIMAXModel produces a lot of logs during fitting. We should give a possibility to disable it.

Proposal

Add parameter fit_params, that should accept Optional[Dict[str, Any]] = None and pass given parameters into fit in etna.models.sarimax._SARIMAXAdapter._get_fit_results.

Add in documentation that this parameter can be used to suppress logging. It can be done like this.

I don't think that this change of the signature can lead to breaking change.

Test cases

We should make sure that given parameters are passed into the model.

Additional context

No response
@Mr-Geekman Mr-Geekman added the enhancement New feature or request label Jul 4, 2023
@github-project-automation github-project-automation bot moved this to Specification in etna board Jul 4, 2023
@Mr-Geekman Mr-Geekman moved this from Specification to In Progress in etna board Jul 4, 2023
@Mr-Geekman Mr-Geekman moved this from In Progress to Todo in etna board Jul 4, 2023
@Mr-Geekman Mr-Geekman added the priority/medium Medium priority task label Jul 4, 2023
@Mr-Geekman Mr-Geekman mentioned this issue Aug 14, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request priority/medium Medium priority task
Projects
etna board
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Mr-Geekman